991073 - New in-content preferences styling squishes certain buttons

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Manish Goregaokar [:manishearth]]

Attachment: Patch 1

The Browse... button on the general tab, the Exceptions buttons on the security tab (and in the privacy tab) all are a bit squished when the new visual polish (bug 738796) is applied.

From browser/themes/shared/in-content/preferences.css, it seems like this was done to "Add margins to this buttons to unsqueeze the checkboxed in same hbox" -- I believe that the new styling makes this unneccesary, but I'm not sure here.

Comment 1

[Manish Goregaokar [:manishearth]]

Attachment: Squished browse button

Comment 2

[Manish Goregaokar [:manishearth]]

Attachment: Squished exceptions buttons

Comment 3

[Manish Goregaokar [:manishearth]]

Attachment: Squished exceptions button in cookies page

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8400651 [details] [diff] [review]
Patch 1

Can't set the review flag whilst uploading a bug :/

Comment 5

[Manish Goregaokar [:manishearth]]

Attachment: Patch 1

Uploaded wrong patch.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8400657 [details] [diff] [review]
Patch 1

Review of attachment 8400657 [details] [diff] [review]:
-----------------------------------------------------------------

Removing those styles for me on Windows 8 now makes those checkboxes squished again.

Comment 7

[Manish Goregaokar [:manishearth]]

I guess I should move the style to windows/ instead and we can find someone who will test on a mac. Thanks.

Comment 8

[Manish Goregaokar [:manishearth]]

Attachment: Patch: Removed from shared theme, added to Windows

I moved the styles to the windows folder. I can't test this on a Mac, though, I'll find someone in fx-team who can.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8400867 [details] [diff] [review]
Patch: Removed from shared theme, added to Windows

Review of attachment 8400867 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, it looks like the patch in bug 989626 made it so that the margin-top and margin-bottom can be removed on Windows.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8400657 [details] [diff] [review]
Patch 1

This is fine now on Windows, but it does make some of the lines vertically closer together.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/bd4f141891a9

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd4f141891a9

Comment 13

[Francesca Ciceri [:madamezou]]

[bugday-20140416]

Hi,

I was able to reproduce it on Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140402030201 CSet: 4941a2ac0786 on Debian Sid, and I can confirm that the problem is no longer present on Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140415030203 CSet: 5b6e82e7bbbf.

Cheers,
Francesca

Comment 14

[Petruta Horea [:phorea], Desktop Test Engineering]

Setting as Verified as per comment 13.