Closed Bug 991111 Opened 6 years ago Closed 5 years ago

Middle clicks on tiles are not counted

Categories

(Tracking Graveyard :: Firefox Operations, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: pauly, Assigned: Mardak)

References

(Depends on 1 open bug)

Details

(Whiteboard: p=5 s=it-31c-30a-29b.3 [qa!])

Attachments

(1 file)

31.0a1 (2014-04-01), win 7 x64
Tiles opened with mouse middle click button (in new tabs) are not counted, NEWTAB_PAGE_DIRECTORY_TYPE_CLICKED doesn't change.

Note: CTRL+left click on tiles (to open them in new tabs) is counted.
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Assignee: nobody → clarkbw
Flags: firefox-backlog+ → firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
Ed can you take a look at this?
Flags: needinfo?(edilee)
pauly, does "NEWTAB_PAGE_SITE_CLICKED" record that the position was clicked with a middle click?
Flags: needinfo?(edilee)
Turns out "click" is not triggered but "mousedown" and "mouseup" do get triggered with event.button == 1. Adding the listener directly to the thumbnail or setting true useCapture or wantsUntrusted don't result in "click" happening on middle click.

Anyone with ideas why? It might be related to the xul/xhtml mix?
Assignee: clarkbw → edilee
OS: Windows 7 → All
Hardware: x86_64 → All
Whiteboard: p=5 s=it-31c-30a-29b.3
Status: NEW → ASSIGNED
Whiteboard: p=5 s=it-31c-30a-29b.3 → p=5 s=it-31c-30a-29b.3 [qa?]
If I add the "click" event listener to document.documentElement (xul:window) or use window.addEventListener, the middle-click "click" event is correctly triggered. All the node ancestors between the xul:window and span.newtab-thumbnail are xhtml.
QA Contact: paul.silaghi
Whiteboard: p=5 s=it-31c-30a-29b.3 [qa?] → p=5 s=it-31c-30a-29b.3 [qa+]
Attached patch v1Splinter Review
Attachment #8406583 - Flags: review?(adw)
Attachment #8406583 - Attachment description: bug991111.patch → v1
(In reply to Ed Lee :Mardak from comment #2)
> pauly, does "NEWTAB_PAGE_SITE_CLICKED" record that the position was clicked
> with a middle click?
Nope
I no longer see the tiles on the NTP in nightly 31.0a1 (2014-04-14). What happened?
Comment on attachment 8406583 [details] [diff] [review]
v1

Review of attachment 8406583 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the test.
Attachment #8406583 - Flags: review?(adw) → review+
(In reply to Paul Silaghi, QA [:pauly] from comment #7)
> I no longer see the tiles on the NTP in nightly 31.0a1 (2014-04-14). What
> happened?

Bug 993581 probably.
Depends on: 996789
https://hg.mozilla.org/mozilla-central/rev/578a88956f7d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 998163
(In reply to Drew Willcoxon :adw from comment #9)
> (In reply to Paul Silaghi, QA [:pauly] from comment #7)
> > I no longer see the tiles on the NTP in nightly 31.0a1 (2014-04-14). What
> > happened?
> 
> Bug 993581 probably.
Is there a way to verify this bug, considering the above?
Flags: needinfo?(edilee)
You can set "browser.newtabpage.directorySource" to "chrome://global/content/directoryLinks.json"

Or you can just look for NEWTAB_PAGE_SITE_CLICKED per comment 6.
Flags: needinfo?(edilee)
Ok, the middle clicks are counted now.
But the right clicks are also counted (even if don't choose anything from the context menu). Is this expected ?
Flags: needinfo?(edilee)
Depends on: 998387
(In reply to Paul Silaghi, QA [:pauly] from comment #14)
> But the right clicks are also counted (even if don't choose anything from
> the context menu). Is this expected ?
I don't think so... I filed a related bug 998387, and it'll be fixed by bug 998163. Although there's a deeper bug/question of if we want/should be counting link visits from the context menu.
Flags: needinfo?(edilee)
Hi Paul, confirming if this resolved bug can be verified before the end of the desktop iteration on Monday April 28?
Flags: needinfo?(paul.silaghi)
Depends on: 997506
No longer depends on: 997506
(In reply to Ed Lee :Mardak from comment #15)
> (In reply to Paul Silaghi, QA [:pauly] from comment #14)
> > But the right clicks are also counted (even if don't choose anything from
> > the context menu). Is this expected ?
> I don't think so... I filed a related bug 998387, and it'll be fixed by bug
> 998163. Although there's a deeper bug/question of if we want/should be
> counting link visits from the context menu.
31.0a1 (2014-04-21)
Right clicks are no longer counted, middle click on the pin/close tile buttons doesn't have any effect, right click/open link in a new tab is also not counted

(In reply to Marco Mucci [:MarcoM] from comment #16)
> Hi Paul, confirming if this resolved bug can be verified before the end of
> the desktop iteration on Monday April 28?
Done. Verified fixed
Status: RESOLVED → VERIFIED
Flags: needinfo?(paul.silaghi)
Whiteboard: p=5 s=it-31c-30a-29b.3 [qa+] → p=5 s=it-31c-30a-29b.3 [qa!]
(In reply to Ed Lee :Mardak from comment #15)
> Although there's a deeper bug/question of if we want/should be
> counting link visits from the context menu.
Please say if you want me to file a new bug for this
Product: Tracking → Tracking Graveyard
You need to log in before you can comment on or make changes to this bug.