Closed Bug 991118 Opened 10 years ago Closed 10 years ago

Link Clicker UI: Going back doesn't end the call

Categories

(Hello (Loop) :: Client, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla33
backlog mlp+

People

(Reporter: standard8, Unassigned)

References

Details

(Whiteboard: [est:2d])

Attachments

(2 files)

STR:

1) Receive a link
2) Click Start, wait for call to be established
3) Click back

Expected results:

Call is ended (and/or maybe a prompt for do I really want to end the call).

Actual results:

The Video is hidden, the call continues and the camera is still connected.
Summary: Loop Clicker UI: Going back doesn't end the call → Link Clicker UI: Going back doesn't end the call
Priority: -- → P3
QA Contact: nperriault
Escalating the priority because this is a security concern.  Folks expect that pressing back arrow will end the call based on other apps in the market.

Niko, can you prioritize fixing this (unless Mark or Dan would prefer to take this)?  Thanks.
Assignee: nobody → nperriault
Priority: P3 → P2
Whiteboard: [est:1d]
backlog: --- → mlp+
Loop-client part of the patch.

This patch does far more than just fixing this issue, it refactors the current architecture heavily, basically moving the sdk session handling to the model, which helps carrying the session information along while navigating using the router.
Attachment #8407752 - Flags: review?(dmose)
Comment on attachment 8407752 [details] [review]
https://github.com/mozilla/loop-client/pull/22

Adding ametaireau for feedback while Standard8 is on PTO and dmose on another timezone atm.
Attachment #8407752 - Flags: feedback?(ametaireau)
Comment on attachment 8407762 [details] [review]
https://github.com/adamroach/gecko-dev/pull/16

Adding ametaireau for feedback while Standard8 is on PTO and dmose on another timezone atm.
Attachment #8407762 - Flags: feedback?(ametaireau)
Comment on attachment 8407752 [details] [review]
https://github.com/mozilla/loop-client/pull/22

I added a bunch of comments on the github pull request.

This looks generally good to me. However, I don't see any test where we try to reproduce the steps that were causing trouble. 

Is it something we don't currently do?
Attachment #8407752 - Flags: feedback?(ametaireau) → feedback+
> However, I don't see any test where we try to reproduce the steps that were causing trouble. 

Indeed. Test added in https://github.com/mozilla/loop-client/commit/edd4d38f8509934a8c09c06617a2e732c9a8e0fc, part of submitted PR.
Comment on attachment 8407752 [details] [review]
https://github.com/mozilla/loop-client/pull/22

r=dmose once any comments are appropriately addressed.
Attachment #8407752 - Flags: review?(dmose) → review+
Whiteboard: [est:1d] → [est:2d]
Comment on attachment 8407762 [details] [review]
https://github.com/adamroach/gecko-dev/pull/16

Clearing obsolete feedback request.
Attachment #8407762 - Flags: feedback?(ametaireau)
Target Milestone: --- → mozilla33
Looks like this landed with tests. Does this need QA testing?
Whiteboard: [est:2d] → [est:2d][qa?]
I confirm that going back now ends a call across all supported branches.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Contact: nperriault → anthony.s.hughes
Whiteboard: [est:2d][qa?] → [est:2d]
You need to log in before you can comment on or make changes to this bug.