Closed Bug 991128 Opened 10 years ago Closed 10 years ago

Link Clicker UI: Unable to reload a page during a call

Categories

(Hello (Loop) :: Client, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla33

People

(Reporter: standard8, Unassigned)

References

Details

Attachments

(1 file)

Currently if I attempt to reload a page during an ongoing call, I am unable to return to the call unless I go back or something.

This is a little strange, we should be able to keep the token and go back to the beginning to invite the user to start the call again.
Priority: -- → P4
QA Contact: nperriault
Blocks: 994274
No longer blocks: 972024
Assignee: nobody → nperriault
This patch updates the url used for ongoing conversation in loop-client, so that it now contains the session token, so we can redirect the user to the call start view if her reloads the page or loads it from a bookmark.
Attachment #8406951 - Flags: review?(standard8)
Attachment #8406951 - Flags: review?(standard8) → review?(dmose)
Comment on attachment 8406951 [details] [review]
https://github.com/mozilla/loop-client/pull/21

r=dmose, comments in the PR
Attachment #8406951 - Flags: review?(dmose) → review+
Landed the patch.  Sorry, Niko, I tried to avoid creating a merge commit, but things got all snarled up, so I ultimately punted rather than sink more time into it.  Next time..

Leaving this bug open until the stuff mentioned in PR is filed / looked in.
Whiteboard: [patch landed; needs another bug filed before closing]
Addressed remaining comments. Created bugs 998272 & bug 998271.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
It looks like this landed with tests. Does this need QA testing?
Whiteboard: [patch landed; needs another bug filed before closing] → [patch landed; needs another bug filed before closing][qa?]
Verified fixed through recent smoketesting.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Whiteboard: [patch landed; needs another bug filed before closing][qa?] → [patch landed; needs another bug filed before closing]
Whiteboard: [patch landed; needs another bug filed before closing]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: