991351 - (mdn-gh-login) Users should be able to log in with their GitHub account

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Sign-in, enhancement)

Description

[Māris Fogels [:mars] (please needinfo)]

What problems would this solve?
===============================
Evidence suggests that a fair number of MDN users have GitHub accounts.  It may be easier for these users to get involved with MDN if they can sign in or sign up with their GitHub account.

Who would use this?
===================
Anyone visiting MDN who has an active GitHub account.

What would users see?
=====================
Logging in to MDN with authentication delegated to GitHub.  Possibly a streamlined signup process as well.

What would users do? What would happen as a result?
===================================================
Standard OAuth sign-in/sign-up delegation, presumably a 'Log in with GitHub' tile like what you find on Stack Overflow's login page.

Is there anything else we should know?
======================================

Comment 1

[Luke Crouch [:groovecoder]]

:lorchard and :jezdez - Let's make the call on django-allauth vs. roll-our-own. (https://github.com/mozilla/kuma/issues/2135)

Comment 2

[Les Orchard [:lorchard]]

(In reply to Luke Crouch [:groovecoder] from comment #1)
> :lorchard and :jezdez - Let's make the call on django-allauth vs.
> roll-our-own. (https://github.com/mozilla/kuma/issues/2135)

My main concerns orbit around the weirdness of MDN's sign-in legacy.

I think the weirdness around the old single-sign-in for Django & Mindtouch & phpBB is so far in the past, that we can ignore it. Though, of course, I always wait for it to be a problem again, lurking somewhere

That just leaves needing to have OAuth/Github and Persona co-exist as sign-in methods, at least for now.  As long as django-allauth can bend into the right shape to deal with that, I'm fine with it.

Comment 3

[Luke Crouch [:groovecoder]]

Holly's first mock-up/wire-frame for the sign-in button: http://cl.ly/image/2w0K3P1n3M0m

Comment 4

[Robert Nyman]

Interesting! I prefer just Step 1, and to show a log-in solely for the option the user chose (whether that's Persona, GitHub etc). If Step 2 is deemed needed (is it?) with showing the choices a second time, I prefer version A.

Comment 5

[Luke Crouch [:groovecoder]]

IIRC, we want Step 2 because users may accidentally click the wrong provider icon (because they are so small) to trigger such a large experience - i.e., redirecting off-site.

Comment 6

[Robert Nyman]

I see. I envisioned it to be a pop-up or similar with some info, potential authorization etc in context for the choice they made, and not send them off directly to another web site, e.g. GitHub.

Comment 7

[Luke Crouch [:groovecoder]]

:habber - do you have a suggestion for pop-up vs. window redirect?

Comment 8

[Les Orchard [:lorchard]]

Making progress wiring up the server backend for GitHub sign-in. 

Since this will probably be easier to revise than a flood of bugzilla comments, I've started assembling a checklist of work I'm discovering along the way along with which bits I've completed:

https://github.com/mozilla/kuma/issues/2135#issuecomment-42215910

Comment 9

[Māris Fogels [:mars] (please needinfo)]

We've launched!  https://groups.google.com/d/topic/mozilla.dev.mdn/BRLSaBAayss/discussion