991499 - WifiWorker still try to send message to component which is already shutdown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect, P1)

Description

[Dimi Lee [:dimi]]

In Bug 987760 , when run test_wifi_setting multiple times, sometimes the test case fail and show :
Exception... "Component returned failure code: 0xc1f30001 
(NS_ERROR_NOT_INITIALIZED) [nsIMessageSender.sendAsyncMessage]

Comment 1

[Dimi Lee [:dimi]]

Attachment: Fix patch v1

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8401175 [details] [diff] [review]
Fix patch v1

Review of attachment 8401175 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thank you. r=me with nit fixed.

::: dom/wifi/WifiWorker.js
@@ +2436,5 @@
>      });
>    },
>  
>    _sendMessage: function(message, success, data, msg) {
> +    try {   

Nit: remove white spaces.

Comment 3

[Dimi Lee [:dimi]]

Attachment: Fix patch v2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ae66a100d164

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae66a100d164

Comment 6

[Vincent Chang[:vchang][changyihsin]]

This should be nominated to 1.3T and approval-mozilla-aurora?

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

Vincent, can you please describe the end user impact of not having this patch and why it is needed for tarako? Thanks

Comment 8

[Vincent Chang[:vchang][changyihsin]]

The patch fixes the regression caused by Bug 979841(1.3T). It may break wifi when open/close content process several times.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

THanks Vincent,

1.3T+ for regression

Comment 10

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/8e200d45fc2b

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8401191 [details] [diff] [review]
Fix patch v2

literally rubber stamping this as there's no indication of the risk/reward here but it's obviously needed for B2G and WiFi workers should not impact desktop/android FF.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0c76505c6dc