991627 - [Tarako] Remove Keyboard settings and dictionaries

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #989268 +++

As an offline discussion with Marvin and Evelyn, need to remove keyboard dictionary and settings since those feature cannot work properly on Tarako and we want to prevent the user from enabling this functions.

--
1. Remove Keyboard settings in 1.3T

 1.1 Click sound, 
 1.2 Auto correction
 1.3 Word suggestion

2. Remove Keyboard dictionaries since they cannot be enabled and to save ROM size.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Marvin,

Need your help to confirm this requirement.
Thanks.

Comment 2

[Evelyn Hung]

We got a few bugs reported that saying keyboard is not responsive (e.g. bug 990457), so rather than making these settings default off, I'd like to remove this feature from 1.3t.

Furthermore, if we do this, we got extra 1.4M memory gain, as well as reduce ROM size.

Comment 3

[Evelyn Hung]

(In reply to Evelyn Hung [:evelyn] from comment #2)

> Furthermore, if we do this, we got extra 1.4M memory gain, as well as reduce
> ROM size.

it's because the en dictionary is 1.4M, and we load the whole file in run time if word suggestion/auto correction enabled.
https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/dictionaries/en.dict

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

over a separate email, Product/TAM confirms this is to be done. 1.3T+

Comment 5

[Marvin Khoo [:Marvin_Khoo]]

Hi Rudy,
Yes, please remove Click sound, Auto correction and word suggestion including corresponding dictionaries.

Please make vibration as default on. Thanks!

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 17980

Tim,

Could you please help review this change?
Thank you.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8401945 [details] [review]
Patch V1 - pull request 17980

Please also remove the dictionary in the build to, either by making the build script skipping copying the dictionary, or actually delete the files (please make sure there isn't any error in build script if you remove the file).

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #7)
> Comment on attachment 8401945 [details] [review]
> Patch V1 - pull request 17980
> 
> Please also remove the dictionary in the build to, either by making the
> build script skipping copying the dictionary, or actually delete the files

Yes, the build script has been modified so that it won't copy the dictionaries.

> (please make sure there isn't any error in build script if you remove the
> file).


Landed to Gaia v1.3t,
https://github.com/mozilla-b2g/gaia/commit/9afe8145b5d309bdf2ef196b559e6dfd997faeeb

Comment 9

[Montoya Clemmons (MClemmons)]

Verified that Click sound, Auto Correction and Word Suggestion removed from keyboard settings in Settings on the latest 1.3T build. Also verified dictionaries do not populate when typing in a text field that provides dictionaries (MMS,Contacts, Email, Calendar)

Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140429014002
Gaia: b5adc5a943d3abbd6ab070a47c847f2c24891cc5
Gecko: e9890f5d4709
Version: 28.1
Firmware Version: sp6821a_gonk4.0_user.pac