991718 - fix homeclean.sh on OS X signing servers

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Amy Rich [:arr] [:arich]]

homeclean.sh keeps reporting the following error in the OSX signing servers:

find: -delete: /Users/archive/: relative path potentially not safe

Comment 1

[Amy Rich [:arr] [:arich]]

it looks like this requires -mindepth 1 because find does some dumb checking on older versions of FreeBSD/OS X:

http://lists.freebsd.org/pipermail/freebsd-hackers/2013-May/042751.html

Not sure how portable this is across architectures, though, so it will require some testing.

Comment 2

[Amy Rich [:arr] [:arich]]

Attachment: adds -mindepth to the find -delete command to stop warning messages on the OS X signing servers

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8408202 [details] [diff] [review]
adds -mindepth to the find -delete command to stop warning messages on the OS X signing servers

I recall using -mindepth on Linux before, so this looks like it should be portable.

Comment 4

[Amy Rich [:arr] [:arich]]

Yeah, I tested it out on one of the centos machines (a foopy running 6.2). I was also going to test it out on the one ubuntu machine listed as topleve::server (the package building box in aws), but it was down.

Comment 5

[Amy Rich [:arr] [:arich]]

Attachment: add a touch to the setup process to change the mtime on the BASE directory

Some OSes (OS X) don't update the mtime on a chmod that doesn't change the permissions, so they'll keep showing the empty base directory in the output even if there's nothing to remove.  This adds a touch to the setup function to update the mtime to avoid this.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8409086 [details]
add a touch to the setup process to change the mtime on the BASE directory

Looks good.  I don't think I *intended* to update the mtime with chmod!

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

merged to production