991844 - [Camera][Buri] Blue highlight Ring around Camera doesn't properly change state when you take a photo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Marcia Knous [:marcia]]

Buri, while running:

Gaia   0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
SourceStamp 91be2828f17e
BuildID 20140403040201
Version 31.0a1
Base Image: 1.2cfg

STR:
1. Open the camera app and take a picture
2. Observe the focus ring sometimes stays blue and doesn't switch back 

Screenshots attached.

This doesn't repro 100%, seems to happen if you quickly take a succession of pictures

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of stuck in blue shutter mode on Buri

Comment 2

[Marcia Knous [:marcia]]

Attachment: What shutter button should look like after you take a picture

Comment 3

[Hema Koka [:hema]]

Please assign a camera engineer to this

Comment 4

[Youngjun Kim]

Dear Marcia,

Is this issue reproduced on Nexus4? We don't have Buri device. 
Please let me know it. 

Thank you.

Comment 5

[Marcia Knous [:marcia]]

I will check on Nexus 4 - Note that this bug was reproduced on a 1.5 build - I will have to check if it reproduces on 1.4 as well.

Comment 6

[Jason Smith [:jsmith]]

Leaving qawanted to check if it reproduces on 1.4.

Comment 7

[Youngjun Kim]

Hyuna can take it. It's reproduced on Nexus4 using latest Master.

Comment 8

[hyuna.cho]

Attachment: PR-991844.html

The controls controller receive the 'ready' event once after taking a picture and updating the preview.
Now, 'ready' event fires twice when success to take a picture and change the preview sate.

If you get the 'ready' event from Camera.prototype.onPreviewStateChange before take successfully, you can see this bug.

Please check it.

Comment 9

[Wilson Page [:wilsonpage]]

Comment on attachment 8401681 [details]
PR-991844.html

- This introduces a new bug around keeping the record button 'pressed' while recording.
- Removing the .release() callback from the 'shutter' event means the capture button is no longer guaranteed to be in sync with the shutter noise.

I think we should hold off on any further work on this until bug 991924 is resolved. I worried we're working around platform issues.

Comment 10

[Montoya Clemmons (MClemmons)]

(In reply to Jason Smith [:jsmith] from comment #6)
> Leaving qawanted to check if it reproduces on 1.4.

User intermittently reproduces issue on 1.4 Buri.

Repro rate: 7/100 = 7 % 

Following the STR from Comment 0, user witnesses focus ring sometimes staying blue and doesn't switch back after rapidly taking pictures in succession. 

Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140404000202
Gaia: b4f3b84ec68233a99fd5865c15cfe28aebe26531
Gecko: 3186bbc50050
Version: 30.0a2
Base image: v1.2-device.cfg

Comment 11

[Jason Smith [:jsmith]]

Note - we'll need the window on master here.

Comment 13

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 14

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8402773 [details] [review]
pull-request (master)

Looks like the 'will-change' CSS stuff from the last patch is in this one as well. It probably needs removed here before you land.

Comment 15

[Wilson Page [:wilsonpage]]

The CSS linter apparently doesn't recognise `will-change` and errors. Not sure what to do about this.

Comment 16

[Montoya Clemmons (MClemmons)]

b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140402145633
Gaia: 7d2ec45b6e23d72f1c5c3bee9547fbdbea5a5f8b
Gecko: d5a8e40b6668
Version: 31.0a1
Firmware: v1.2-device.cfg

First Broken Environmental Variables:
Device: Buri 1.5 MOZ
BuildID: 20140402151134
Gaia: 4f8805198e6b5f79bf4b2f4f5e14d6c9c276b180
Gecko: d67f8c25a033
Version: 31.0a1
Firmware: v1.2-device.cfg

Last Working Gaia / First Broken Gecko: Issue does NOT reproduce
Gaia: 7d2ec45b6e23d72f1c5c3bee9547fbdbea5a5f8b
Gecko: d67f8c25a033

First Broken Gaia  / Last Working Gecko: Issue DOES reproduce 
Gaia: 4f8805198e6b5f79bf4b2f4f5e14d6c9c276b180
Gecko: d5a8e40b6668

Gaia Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/7d2ec45b6e23d72f1c5c3bee9547fbdbea5a5f8b...4f8805198e6b5f79bf4b2f4f5e14d6c9c276b180

Comment 17

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/1958454595b1fa0e061f0652ae965629993f5708

Comment 18

[Wilson Page [:wilsonpage]]

The landed fix makes sure that the highlighted capture button always restores when the camera becomes 'ready'. Unit-tests added to prove some ControlsController functionality.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/ecc2f21fb2530398ab3f243c6307728013646678

Comment 20

[sarsenyev]

I still was able to reproduce the issue on the latest 1.4 build
Camera's ring stays blue after taking a picture
It happened when I long tapped the shutter icon and without releasing a finger the camera took a picture, when I released a finger the ring stayed blue
It's low repro but still reproduces.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140411000202
Gaia: 6c50349f41d40ba175ea0fc0c2c2cbd739ba7170
Gecko: 28b419f0e857
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Comment 21

[sarsenyev]

Also it reproduces on Master builds, same scenario.

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140411000202
Gaia: 6c50349f41d40ba175ea0fc0c2c2cbd739ba7170
Gecko: 28b419f0e857
Version: 30.0a2
Firmware Version: v1.2-device.cfg

1.5 Environmental Variables:
Device: Buri 1.5 Master
BuildID: 20140411040203
Gaia: 1368d716072adf308e1b435ac828f97545a045f1
Gecko: d8c1b10c3a3d
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Comment 22

[Jason Smith [:jsmith]]

Wilson - Are you able to reproduce what comment 20 is indicating?

Comment 23

[Wilson Page [:wilsonpage]]

Unable to reproduce on 1.4 or master. Capture button remains blue until shutter fires, then returns to default state.