991924 - [Camera][Buri] Performance regression when selecting shutter button (camera and video)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Marcia Knous [:marcia]]

Buri, while running:

Gaia   0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
SourceStamp 91be2828f17e
BuildID 20140403040201
Version 31.0a1
Base Image: 1.2cfg

Noticed the bug after the landing of the blue highlight.

STR:
1. Open the camera app and take a picture
2. Shutter button is slow to fire since the blue highlight has to draw (sometimes it appears to get stuck, which is filed as Bug 991844).

The video button is also slow to respond to touch events as well on Buri, so it is not just the camera shutter button.

Comment 1

[Youngjun Kim]

Hyuna can take it. It's reproduced on Nexus4 using latest Master.

Comment 2

[hyuna.cho]

Bug 991844 patch will cover this bug.
Please check it with Bug 991844 patch

Comment 3

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 4

[Wilson Page [:wilsonpage]]

Found the introduction of `will-change` seemed to be causing a rendering regression on lower powered devices.

Comment 5

[Wilson Page [:wilsonpage]]

I'm pretty sure something is very wrong at graphics layer. I'm experiencign lots of weirdness with the latest build. I filled bug 992271 to track this.

I don't want us to land any work arounds in camera if this is a platform regression.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Marcia: So, I agree with Wilson, this seems to be a platform regression. Using the following build (one build newer than the one you reported this bug with), the performance regression doesn't seem nearly as bad:

Gaia      d9a574284d672f532f7c562a091bb01f531202b1
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c924a018540
BuildID   20140403160202
Version   31.0a1
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

Can you confirm?

Comment 7

[Justin D'Arcangelo [:justindarc]]

Also, I'm not seeing the same level of performance regressions with latest PVT build from today either:

Gaia      d9a574284d672f532f7c562a091bb01f531202b1
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c924a018540
BuildID   20140404040204
Version   31.0a1
ro.build.version.incremental=eng.tclxa.20131223.163538
ro.build.date=Mon Dec 23 16:36:04 CST 2013

Comment 8

[Justin D'Arcangelo [:justindarc]]

Some more findings:

I flashed *gecko* only from 3 days ago combined with the latest gaia from several minutes ago and found that all the performance issues seem to be gone. I still do not think that all the performance regressions in gecko are resolved with today's build since the gecko build from 3 days ago is blazing fast.

Gecko     https://hg.mozilla.org/mozilla-central/rev/1417d180a1d8
BuildID   20140401040202
Version   31.0a1

and Gaia: 8d7f1842b51460f3e769e8466023ba092aa092df

Comment 9

[Marcia Knous [:marcia]]

In just testing this again today, the difference between 1.4 and master seems to be very apparent - it is most noticeable when pressing the shutter button and taking a picture from the camera app. I am running on Buri using the same build that Justin is in Comment 7.

Gaia   d9a574284d672f532f7c562a091bb01f531202b1
SourceStamp 6c924a018540
BuildID 20140404040204
Version 31.0a1

Comment 10

[Justin D'Arcangelo [:justindarc]]

Marcia: Yes, the performance regression is still there, although I don't think its quite as bad as yesterday's. I've narrowed it down to be a Gecko issue though by using the Gecko/Gaia combination in Comment 8.

Comment 11

[Wilson Page [:wilsonpage]]

The patch attached seems to massively improve performance on the Hamachi and also addresses an issue whereby the capture button can get stuck in pressed state if the camera errors. Still finding other rendering issues though.

Justin: Do you think we should land this?

Comment 12

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8401798 [details] [review]
pull-request (master)

R+ for the updated PR that is CSS-only to remove the `will-change` properties.

Comment 13

[Wilson Page [:wilsonpage]]

Landed on 'master': https://github.com/mozilla-b2g/gaia/commit/0936a559747fcabc48f738324972230cc7e76968

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/a3ff60782a9b94d4eba59bb65ac7c3aa800b6629