99209 - modify dependency tree bugs

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement, P3)

Description

[Gagan]

Need a way to bulk change the bugs under a dependency tree. Just like the way
the query results page offers a way to make changes to several of those bugs,
we'd like to be able to make changes to several bugs based on the dependency tree.

Comment 1

[Matthew Tuck [:CodeMachine]]

I suppose this is asking for a query condition that does a transitively closed
dependency relation.  If not, this should have been fixed by bug #30823.

Comment 2

[Gagan]

*** Bug 103194 has been marked as a duplicate of this bug. ***

Comment 3

[Asa Dotzler [:asa]]

an addition of the buglist.cgi footer (slightly modified) to the
showdependencytree.cgi page is what I think we're looking for here. Something
like this at the bottom of showdependencytree.cgi:

Change several of these bugs at once  |  Show dependency tree as query for
editing  | Show depencency tree as buglist

This bug is requesting a footer with links that makes the dependency tree view
more useful.

Comment 4

[Matthew Tuck [:CodeMachine]]

None of these things could be done properly without a transitively closed
dependency relation.  I suppose we could make this stuff pass a list of bug
numbers, but that couldn't use a link or it would hit URL limits.

Comment 5

[Gagan]

matty: let the owner of the bug decide the milestone. thanks.

Comment 6

[Dave Miller [:justdave]]

Gagan: I'm perfectly happy allowing Matty to set milestones for Bugzilla bugs. 
He's the QA for Bugzilla if you might notice, part of his job (at least the way
we use him) besides making sure we actually fixed things, is to assist us with
bug triage.  However...

Matty: The infrastructure for this is ALREADY in place, because we now have a
link to view the dependency tree as a buglist.  All that needs to be changed is
to add an additional link with exactly the same URL with the addition of the tag
to tell buglist.cgi to display the page in "change several" mode.  Since this is
more or less a "no-brainer" fix, I see no reason to push it off for "Future".

Setting for 2.18, but only because it's an enhancement request without a patch
supplied.  I'll be happy to put it in 2.16 if there's a patch before then.

Comment 7

[Matthew Tuck [:CodeMachine]]

Gagan: Our process is different from the Mozilla process.  Please don't make
assumptions about it.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: adds link to dependency tree page

This patch adds a link to the page, and it also suppresses display of the "view
as bug list" link unless there is more than one bug in the list.

Comment 9

[Gagan]

matty: my apologies at reacting to your group's triaging process without
understanding it -- in any case I am happy to see this bug being targetted for
earliar. 

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Has a low-risk patch: re-targeting to current milestone.  Patch needs review:
setting appropriate keywords.

Comment 11

[Bradley Baetz (:bbaetz)]

Comment on attachment 57560 [details] [diff] [review]
patch v1: adds link to dependency tree page

>Index: showdependencytree.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v
>retrieving revision 1.13
>diff -u -r1.13 showdependencytree.cgi
>--- showdependencytree.cgi	2001/11/08 02:43:55	1.13
>+++ showdependencytree.cgi	2001/11/13 04:54:31
>@@ -221,9 +221,14 @@
>     $html = "<h3>Bugs that bug $linked_id ".($target eq "blocked" ? 
>         "blocks" : "depends on");
> 
>-    if ((scalar keys %printed) > 0) {
>+    if ((scalar keys %printed) > 1) {

Why this change? It may be a silly option to edit bugs at once when there is
one bug, but its a legal
one.

>         $html .= ' (<a href="buglist.cgi?bug_id=' . join(',', keys %printed) . 
>-                 '">view as bug list</a>)';        
>+                 '">view as bug list</a> ';        

Theres an extra space at the end, there.

>+        if (UserInGroup("editbugs")) {
>+            $html .= ' | <a href="buglist.cgi?bug_id=' . join(',', keys %printed) . 
>+                     '&tweak=1">change several</a>';
>+        }
>+        $html .= ') ';

...and there

Comment 12

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: fix bbaetz's issues and clean up code

bbaetz:

You're right, a one-bug bug list is legal.  It's the "change several bugs" page
that expects to have more than one bug.  I have changed the code accordingly so
that a one bug tree still shows the "view as bug list" link but the "change
several" link requires more than one bug in the tree.

Other than that two spacing issues have been fixed, I added some documentation,
and I separated out definition of the link for code clarity.

Comment 13

[Gervase Markham [:gerv]]

Why can the user not just do "View as Bug List" and then "Change several bugs at
once"? Is this just to save a click?

Gerv

Comment 14

[Bradley Baetz (:bbaetz)]

grr. Missed this because I wasn't ccd.

Gerv: That wasn't an option when this bug was filed - you only added that on
16/10 according to cvs. That said, I'm guessing that it could be useful if there
were lots of bugs.

r=bbaetz if we still want this (and someone tests on an installation with more
than the 3 bugs I have in mine...)

Comment 15

[Christian Reis]

Comment on attachment 65424 [details] [diff] [review]
patch v2: fix bbaetz's issues and clean up code

r=kiko
i'm okay with this going in now

marked bradley's review

Comment 16

[Myk Melez [:myk] [@mykmelez]]

Checking in showdependencytree.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <-- 
showdependencytree.cgi
new revision: 1.15; previous revision: 1.14
done

Comment 17

[Myk Melez [:myk] [@mykmelez]]

Patch checked in.  Resolving fixed.