992233 - Bug 984153 regressed the background color for suggestions list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

Attachment: screenshot.png

Because of the patch in Bug 984153, the background color of the suggestion list is grey instead of white because the specificity of the new selector is higher than the one at [1].

So we need to use a selector with lower specificity to fix bug 984153. Maybe add a class instead of an id? I'd hate to put more specificty at [1]...

[1] https://github.com/mozilla-b2g/gaia/blob/0aaacfb35bc914814904a02a49e1abb9a56ac099/apps/sms/style/sms.css#L973

Requesting 1.4+ because bug 984153 landed in 1.4.

Comment 1

[Kai-Chih Hu [:khu]]

Steve, any update? Thanks.

Comment 2

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Julien, that's the minimum css changes I could thoug that only apply grey background color for the ul not contained contact-list class.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8407446 [details] [review]
Link to github

I really open to make it cleaner by adding some more code. One proposal on github is to add a specific class to ULs used as message containers.

Comment 4

[Jason Smith [:jsmith]]

Retriage - this is minor user impact, so I think we can live with this.

Comment 5

[Julien Wajsberg [:julienw]]

I'm not sure UX would agree with you here, Jason.

Comment 6

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage with UX, make it white as expected.

Comment 7

[Julien Wajsberg [:julienw]]

Steve: since it's 1.4+, I'm fine with your patch on the branch (didn't try it yet though) but I'd like another patch for master then, using a class.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Wesley Huang [:wesley_huang] from comment #6)
> triage with UX, make it white as expected.

I don't think that's makes this a compelling argument to block. That just means that they agree it's a bug.

Comment 9

[Jason Smith [:jsmith]]

Alright I got the explanation of why this is a blocker. User testing has found that grey indicates to a user that the UI is not clickable, so having a grey background here means the UI risks never being used.

Comment 10

[Steve Chung [:steveck]]

Comment on attachment 8407446 [details] [review]
Link to github

As you wish :) I add a 'message-list' class for it.

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8407446 [details] [review]
Link to github

r=me with the additional CSS change; pick your prefered proposal, just remove that id :)

Comment 12

[Steve Chung [:steveck]]

in master: 559c4b4d8bf5bfeb5c6ad7a22ddcf01949f15c74

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Needs a branch patch for v1.4 uplift.

Comment 14

[Steve Chung [:steveck]]

in v1.4 : 3c53bebcc7541e5d19c96cf38ee2603927478f3c