992271 - [Camera] Broken graphics

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Wilson Page [:wilsonpage]]

Attachment: camera-graphics.png

Graphics breakages and slow rendering on recent builds. Don't think this is directly related to camera app.

Comment 1

[Wilson Page [:wilsonpage]]

Needinfo mikeh as he is my only connection to the world of Gecko :)

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Over to the graphics expert.

Comment 3

[Justin D'Arcangelo [:justindarc]]

tif: Just wanted to put this on your radar too. It looks like this may be related to the weird issue you saw yesterday where there was only half of a Zoom Bar.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Please see my findings in Bug 991924

Summary: Gecko from a few days ago combined with latest Gaia has no performance issues. Gecko from yesterday onward is causing major performance problems, especially on Hamachi.

Comment 5

[Tiffanie Shakespeare [:tif]]

Thanks Justin - I"ll look at master again today and see if I can still repro. I noticed that later in the day after flashing the weird zoom bar issue seemed to go away.

Comment 6

[Sotaro Ikeda [:sotaro]]

It seems to be caused by Bug 980647.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Something very strange going on here.. *major* performance issues on hamachi, but seeing strange graphics "glitches" on nexus4 as well (no perf issues there though).

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

If this is caused by bug 980647, that just got backed out today, we should test tomorrow.

However, it is not clear to me that if this is 1.4 or trunk - can somebody verify?

Comment 9

[No-Jun Park [:njpark]]

Actually, I'm not sure what is the STR, but on latest master branch, I do not see this issue:

Gaia      f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko     https://hg.mozilla.org/mozilla-central/rev/5405d6f4e3c6
BuildID   20140407040202
Version   31.0a1

Comment 10

[Justin D'Arcangelo [:justindarc]]

Attachment: nexus4-graphics.png

Here's an example of the graphics glitches I'm talking about. On Nexus4 using master:

1. open Camera
2. press lock button to lock screen
3. press lock button to return to lockscreen
4. slowly swipe to "unlock" on lockscreen
5. see crazy flickering of graphics near bottom of screen (see attachment)

Comment 11

[Justin D'Arcangelo [:justindarc]]

Attachment: hamachi-graphics.png

I'm not even sure how I got this to happen, but when trying to record a video using latest gecko/gaia (master), the Camera controls just froze up (video preview was still playing) and at some point, half of the photo/video toggle switch just disappeared. Also, using this build, the pinch-to-zoom and zoom bar are almost unusable because of the slowness in painting the screen.

Gaia      f1a98bfaa3ab2480945bd7018831fd56c61cdc24
Gecko     https://hg.mozilla.org/mozilla-central/rev/5405d6f4e3c6
BuildID   20140407040202
Version   31.0a1

Comment 12

[Sotaro Ikeda [:sotaro]]

Can someone take a logcat?

Comment 13

[No-Jun Park [:njpark]]

Attachment: Logcat when screen freeze happens

I can reproduce this now, with a slightly different STR:
Enter Camera App
Lock screen by pressing power button
Press power button again, and swipe to the left (camera) to unlock
Lock screen by pressing power button again
Press power button again, and swipe to the right (App) to unlock

Expected:
Camera view should be shown

Actual:
Screen just froze, not displaying anything.

Comment 14

[No-Jun Park [:njpark]]

Logcat in Comment 13 is from the last step, because when you press power button, logcat process dies.

Comment 15

[Sotaro Ikeda [:sotaro]]

In attachment 8402859 [details], there are some genloc failures. Bug 980647 seems to cause this.

> E/QCameraHWI_Preview(  138): getBufferFromSurface: camera call genlock_lock, hdl=0x1a25e78
> E/QCameraHWI_Preview(  138): getBufferFromSurface: genlock_lock_buffer hdl =0x1a25e78

Comment 16

[Justin D'Arcangelo [:justindarc]]

Attachment: logcat of all sorts of hamachi gfx fail

Here's a logcat as requested. Not sure if I grabbed anything useful. During this logcat, I was attempting to use the Camera and the gfx were failing badly. I was probably getting 2-3fps throughout. Ultimately, it ended up freezing so badly that the UI was almost completely unresponsive.

Comment 17

[Sotaro Ikeda [:sotaro]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #16)
> Created attachment 8402863 [details]
> logcat of all sorts of hamachi gfx fail

This also has some genlock failure.

E/libgenlock(  565): perform_lock_unlock_operation: GENLOCK_IOC_DREADLOCK failed (lockType0x1, err=Connection timed out fd=86)
E/msm7627a.gralloc(  565): gralloc_lock: genlock_lock_buffer (lockType=0x2) failed
W/GraphicBufferMapper(  565): lock(...) failed -22 (Invalid argument)

Comment 18

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #15)
> In attachment 8402859 [details], there are some genloc failures. Bug 980647
> seems to cause this.
> 
> > E/QCameraHWI_Preview(  138): getBufferFromSurface: camera call genlock_lock, hdl=0x1a25e78
> > E/QCameraHWI_Preview(  138): getBufferFromSurface: genlock_lock_buffer hdl =0x1a25e78

Sorry, the above is not genlock failure log.

Comment 19

[Sotaro Ikeda [:sotaro]]

(In reply to Milan Sreckovic [:milan] from comment #8)
> If this is caused by bug 980647, that just got backed out today, we should
> test tomorrow.
> 
> However, it is not clear to me that if this is 1.4 or trunk - can somebody
> verify?

I suspect it happens only on trunk. I am going to check it.

Comment 20

[Justin D'Arcangelo [:justindarc]]

Yes, only happening on master as far as I can tell.

Comment 21

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #19)
> (In reply to Milan Sreckovic [:milan] from comment #8)
> > If this is caused by bug 980647, that just got backed out today, we should
> > test tomorrow.
> > 
> > However, it is not clear to me that if this is 1.4 or trunk - can somebody
> > verify?
> 
> I suspect it happens only on trunk. I am going to check it.

The following was committed only to trunk(master).
https://hg.mozilla.org/integration/mozilla-inbound/rev/941bee559cd7

Comment 22

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks - no need for 1.4 flag then.

Comment 23

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #19)
> (In reply to Milan Sreckovic [:milan] from comment #8)
> > If this is caused by bug 980647, that just got backed out today, we should
> > test tomorrow.
> > 
> > However, it is not clear to me that if this is 1.4 or trunk - can somebody
> > verify?
> 
> I suspect it happens only on trunk. I am going to check it.

I also confirmed that the problem happens only on master on hamaci.

Comment 24

[Jason Smith [:jsmith]]

Fixed via backout of bug 980647. Reopen if that's not the case.

Comment 25

[Justin D'Arcangelo [:justindarc]]

Just confirming, with latest nightly build, this seems to be resolved for me.