992284 - [Australis - OSX] Extension icons looks weird

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Mehmet]

Attachment: bug.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.74.9 (KHTML, like Gecko) Version/6.1.2 Safari/537.74.9

Steps to reproduce:

OSX 10.8.5
Firefox Beta - Trunk


1.) Install Adblock
2.) Extension icon looks okay in the Toolbar
3.) Close the window
4.) Open a new window


Actual results:

The extension icon looks squeezed.


Expected results:

It should look normal.

Comment 1

[Mehmet]

Attachment: okay.png

Comment 2

[Mehmet]

Two screenshots are attached in previous comments: bug vs. okay

(Adding: Blocks 870032)

Comment 3

[Justin Dolske [:Dolske]]

I can't reproduce this in a new profile. Perhaps another addon is causing it?

Comment 4

[Mehmet]

Nothing else is installed.

Maybe it depends on the screen and resolution ?

I am using a MacBookAir 11''.

Comment 5

[:Gijs (he/him)]

Perhaps this depends on the abp version?

Comment 6

[Wladimir Palant]

No, I'm fairly certain that this isn't related to Adblock Plus versions. This screenshot shows a scaled version of the 24x24 Adblock Plus icon, not the 16x16 icon. This one would be displayed if iconsize="small" is missing on the toolbar - I changed it into iconsize="large" manually and verified that it looks like in the screenshot attached. I suspect that some outdated attribute value is stuck in localstore.

Comment 7

[Matthew N. [:MattN]]

This is likely due to one of the problems with our migrateUI function for users who downgrade a profile: We won't re-migrate them if they upgrade again since the pref will still indicate they already have that migration step completed. If this is the cause, it means the bug won't affect people who don't downgrade. I'm not sure it's worth improving migrateUI for this case.

Ideally migrateUI would replay migrations after downgrading and then upgrading but there are times when this wouldn't be what the user wanted because there is some possible dataloss involved e.g. if the user already manually adjusted something that the migration "broke" for them. It's a tricky situation for a minority of users.

Mehmet, can you confirm you used this profile in a version < 29 since using it on 29?  Can you confirm that setting the pref browser.migration.version to 17 in about:config and then restarting fixes the problem?

Comment 8

[Mehmet]

Attachment: with separator vs. without separator

(In reply to Matthew N. [:MattN] from comment #7)
> Mehmet, can you confirm you used this profile in a version < 29 since using
> it on 29?  Can you confirm that setting the pref browser.migration.version
> to 17 in about:config and then restarting fixes the problem?

Yes, it is partially fixed with the above setting pref. I got the small icon, but I (still) see two different states of the hover button.

1.) >>with<< separator

2.) >>without<< separator



(You receive the button with the separator, when you hide the button, and bring it back via customizing. Closing the window and open a new window brings the window without separator. Not sure which one is the expected one.)


Screenshots are attached.

Comment 9

[Mehmet]

Sorry I forget to answer to the first part: Yes I used the profile in a version < 29 since using it on 29.

Comment 10

[:Gijs (he/him)]

(In reply to Mehmet Sahin from comment #8)
> Created attachment 8403429 [details]
> with separator vs. without separator
> 1.) >>with<< separator
> 2.) >>without<< separator

No idea on this count. Wladimir?

In the meantime, I'll write up a patch to make restore defaults fix the iconsize like it's fixing the mode (bug 989289 did that).

Comment 11

[Wladimir Palant]

(In reply to Mehmet Sahin from comment #8)
> (You receive the button with the separator, when you hide the button, and
> bring it back via customizing. Closing the window and open a new window
> brings the window without separator. Not sure which one is the expected one.)

That's bug 981543, already fixed in the Adblock Plus development builds - next Adblock Plus release won't be affected.

Comment 12

[Mehmet]

Can't reproduce this any longer in FF58. Closing my old bug.