Closed Bug 992664 Opened 10 years ago Closed 8 years ago

Ensure <track> captions are visible for audio-only files in <video>

Categories

(Core :: Audio/Video: Playback, defect)

25 Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- wontfix
firefox31 --- wontfix
firefox32 --- wontfix
firefox33 --- wontfix
firefox34 --- wontfix
firefox-esr24 --- unaffected
firefox-esr31 --- wontfix

People

(Reporter: mardeg, Assigned: alwu)

References

(Blocks 1 open bug, )

Details

(Keywords: regression, testcase)

STR
1. Load the testcase linked from the URL field
2. Play the first <video>
3. Notice the captions are hidden behind the controls

Expected results: Captions are visible, see the workaround videos in the corresponding browser versions

Actual results: Captions are obscured/unreadable

This was working around June last year when bug 886748 comment 3 was made.
Blocks: webvtt
Keywords: testcase
Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3192742f570a&tochange=a38f49d05074

Regressed by:
0219548b1ef2	Ralph Giles — Bug 887463 - remove webvtt parser library. r=cpearce.
Blocks: 887463
Target Milestone: mozilla29 → ---
Version: 31 Branch → 25 Branch
I'm guessing the problem here is that we don't hide the controls if there's no video track. The controls also cover the captions if I test with a video the same size as the default <video> box, 300x150, but it's less of a problem because we hide the controls on unhover.

Rick, can we re-layout the captions using the visible area of the frame instead of the whole video?

I also notice captions don't adapt properly in fullscreen mode. They continue to show in their original location.
(In reply to Ralph Giles (:rillian) from comment #2)
> I'm guessing the problem here is that we don't hide the controls if there's
> no video track. The controls also cover the captions if I test with a video
> the same size as the default <video> box, 300x150, but it's less of a
> problem because we hide the controls on unhover.
> 
> Rick, can we re-layout the captions using the visible area of the frame
> instead of the whole video?

I'm not quite sure what you mean, but we would just have to change what block level element we're passing into the layout algorithm here: http://dxr.mozilla.org/mozilla-central/source/content/html/content/src/TextTrackManager.cpp


> I also notice captions don't adapt properly in fullscreen mode. They
> continue to show in their original location.

This is a known issue. See bug 976580. The problem is that we aren't setting the cue's layout state to dirty when we resize the video so the display states aren't recalculated. I'm going to aim to land the fix for this in 31.
Rick, is this something that can be fixed in time for 31? If not, should we be delaying WebVTT for another release? The final beta goes to build today so we're nearing the point of no return.
If our freeze deadline is today, I think it's too late to actually fix this for 31. We should either release as-is, or disable the feature.
Sorry, for the late reply. I think Ralph sorted out based on mine and his convo earlier. Especially since it's now released.
Flags: needinfo?(rick.eyre)
Yes, we released with this bug still present; a fix is still needed for newer releases.
(In reply to Ralph Giles (:rillian) from comment #8)
> Yes, we released with this bug still present; a fix is still needed for
> newer releases.

Assuming Firefox 31esr and 34.0a1 carry this bug as well.
I doubt that any of them wouldn't. I don't think we ever had this working at any point.
(In reply to Rick Eyre (:reyre) from comment #10)
> I doubt that any of them wouldn't. I don't think we ever had this working at
> any point.
This was working before bug 887463 landed.
Component: Audio/Video → Audio/Video: Playback
Assignee: nobody → alwu
This issue was fixed by bug985915.
Now the caption would be showed correctly and doesn't be covered overlapped with video control interface.

BTW, the link in "URL" is wrong, the website was using the wrong vtt src.
You can use this link [1] to verify this issue.

[1] http://people.mozilla.org/~alwu/WebVTT/test.html
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.