985977 - [WebVTT] Fix issues in 29 and 30 so that we can keep the WebVTT pref on

Status: RESOLVED WONTFIX

(Core :: Audio/Video, defect)

Description

[Rick Eyre (:reyre)]

Bug 981280 brought up the issue that the track and webvtt implementation is too buggy to turn on. Based on that we disabled it for FF28.

Moving forward we either need to turn the pref off for FF29 and 30 or we need to determine what needs to be fixed in 29 and 30 for the pref to be able to stay on.

The main issues were the fact that automatic track selection wasn't working correctly, there was no way to remove tracks added through trackelement, and finally subtitles with 'hidden' value were displaying.

If we want to fix these issues in FF29 and 30 I think we would need to land:

- Bug 977302
- Bug 977299
- Bug 983207

Maybe a few others need to land that these ones are dependent on as well.

Comment 1

[Rick Eyre (:reyre)]

How many patches do you think would be too many to uplift into beta/aurora to keep the pref on Chris? I'd like to get an idea of how much would be too much. I suspect the answer would be 'as little as possible'.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Typically we try not to uplift "features", and only uplift stabilization patches to aurora, and crash/security fixes to beta.

So if any of the patches you want to uplift don't follow those guidelines, I'd suggest we let them ride the trains, and disable WebVTT in other branches.

Comment 3

[Rick Eyre (:reyre)]

Okay, if that's the case then I think we're looking at turning off the pref for at least FF29 and possible 30 as well. The problems that we disabled it for have just been fixed in FF30. So if you agree I can put together a patch to turn the pref off in 29/30.

Comment 4

[Rick Eyre (:reyre)]

(In reply to Rick Eyre (:reyre) from comment #3)
> Okay, if that's the case then I think we're looking at turning off the pref
> for at least FF29 and possible 30 as well. The problems that we disabled it
> for have just been fixed in FF30. So if you agree I can put together a patch
> to turn the pref off in 29/30.

Sorry, the issues have just been disabled in *31*. Not 30.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Ok, pref it off in 29/30.

Comment 6

[Rick Eyre (:reyre)]

(In reply to Chris Pearce (:cpearce) from comment #5)
> Ok, pref it off in 29/30.

Okay, sounds good. I'll add those patches to disable it to bug 981280.