Closed Bug 992963 Opened 6 years ago Closed 5 years ago

Enable search activity in Nightly builds

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

All
Android
defect
Not set

Tracking

(firefox34 verified, fennec34+)

VERIFIED FIXED
Firefox 34
Tracking Status
firefox34 --- verified
fennec 34+ ---

People

(Reporter: blassey, Assigned: eedens)

References

Details

Attachments

(1 file, 9 obsolete files)

No description provided.
Attached patch android_search.patch (obsolete) — Splinter Review
This gets us registered such that we can replace google now. We should probably have some new UX for this to take you to.
Assignee: nobody → blassey.bugs
Attachment #8402847 - Flags: feedback?(mark.finkle)
Attachment #8402847 - Flags: feedback?(ibarlow)
Brad, can you provide a little more background here? What is this enhancement about?
Ian - We were talking about how it is possible to be treated as a global search provider on Android. If you use the "swipe from bottom of screen upward" you activate the global search provider. Usually this just launches Google Now. If you also have Bing installed, you see the Intent Chooser appear and let you decide between Google and Bing.

Brad's patch adds Firefox to that list.

The question becomes: What activity would Firefox want to open in response? We could display the Awesomescreen, or we could create something new and very search oriented.
tracking-fennec: ? → 33+
Assignee: blassey.bugs → jdover
If I guess at the activity in the AndroidManifest, this should open the regular Firefox application activity in response to the gesture.

Would we ever want to land that as is? I don't think we do. Let's get Josh to start an new activity, purely for Searching.
Attachment #8402847 - Flags: feedback?(mark.finkle)
Attachment #8402847 - Flags: feedback?(ibarlow)
Josh is working on this. He's starting with a basic new activity that just queries our history/search providers, but with an eye to building out from that. Hopefully we can talk next week when Mark's in town a bit too. I can schedule a meeting with UX if they want to come.
Attached patch Early WIP - Add activity (obsolete) — Splinter Review
Attachment #8402847 - Attachment is obsolete: true
These early WIPs add a new activity and *attempt* to reuse the ToolbarEditText view and the BrowserSearch fragment to provide search suggestions / history & bookmark search. 

As of now, this version requires you to launch Fennec first and then open the search utility (either via swipe up from home or the launcher). The parts that depend on Fennec are:

- Search engines - these are provided from Gecko, they have be stored in a file somewhere so we can eliminate this dep)
- Favicons - there is some initialization that I haven't been able to find/satisfy yet related to the LoadFaviconTask. The exception that is throwing is a ExceptionInInitializerError.

The other possibility is that we actually do some of fennec's initialization in the background (including starting Gecko?) when this activity is launched so that when a user clicks on a link the browser starts faster.
Build for those who want to try it out. See note above about launching.

https://drive.google.com/file/d/0BwqqgfwYmRg4cldJWWkyWDJPbzg/edit?usp=sharing
The app is registered as search provider, and the "Firefox search screen" is display. But when I click on an service (like google, yahoo, twitter), nothing happens. Is it related to dev environnement ?

I'm on a Nexus 5.
(In reply to Jule Schz from comment #9)
> The app is registered as search provider, and the "Firefox search screen" is
> display. But when I click on an service (like google, yahoo, twitter),
> nothing happens. Is it related to dev environnement ?
> 
> I'm on a Nexus 5.

Yep I have the same problem, this is definitely no where near ready for usage
yet. I just whipped this up on Friday to give us an idea of what challenges
there would be in reusing these components from the main activity.
Attachment #8405617 - Attachment is obsolete: true
Attachment #8405618 - Attachment is obsolete: true
Josh - I don't know about your availability now that you're no longer an intern. Let us know what you can and can't take on.

I'll start looking for a few others to pitch in and learn the patches.
Eric is working on this now!
Assignee: bugs → eedens
Blocks: search
I'm marking depends-on Bug 1017078, even though it's not a strict dependency, because See Also kinda sucks. We should specifically record searches performed.
Status: NEW → ASSIGNED
Depends on: 1017078
OS: Mac OS X → Android
Hardware: x86 → All
Summary: register as a global search provider for Android → Register as a global search provider for Android
Oh, margaret beat me to it, and to the meta bug. Much better!
No longer depends on: 1017078
Component: General → Search Activity
tracking-fennec: 33+ → 34+
Attachment #8414859 - Attachment is obsolete: true
Attachment #8414860 - Attachment is obsolete: true
Attachment #8414861 - Attachment is obsolete: true
Attachment #8414862 - Attachment is obsolete: true
Attachment #8414863 - Attachment is obsolete: true
Attachment #8414864 - Attachment is obsolete: true
This bug is essentially fixed, we just need to flip a build flag to turn this on in Fennec.

So, let's make this bug about flipping that flag when the time is right - hopefully pretty soon!
Summary: Register as a global search provider for Android → Enable search activity in Nightly builds
Want to write a patch to flip the build flag?

We should make a try run just to make sure this doesn't screw up any automation.
Flags: needinfo?(eric.edens)
This patch enables the search activity in nightly, as described in Nick's blog: http://www.ncalexander.net/blog/2014/07/09/how-to-land-a-fennec-feature-behind-a-build-flag/

There are two Try builds:
1. Conditional build flag (this patch): https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=18308b1b299f
2. Non-conditional build flag: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fb37b0faad78
Attachment #8465839 - Flags: review?(margaret.leibovic)
Flags: needinfo?(eric.edens)
Comment on attachment 8465839 [details] [diff] [review]
bug-992963-fix.patch

Review of attachment 8465839 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! If the try runs go green all that we need is the icon patch, and then I'll land this.
Attachment #8465839 - Flags: review?(margaret.leibovic) → review+
The Try builds look alright. There was an intermittent error on RC3 for [1], but it re-ran without problems three times. 

[1] https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=fb37b0faad78
https://hg.mozilla.org/mozilla-central/rev/8593b668b998
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.