Closed Bug 993039 Opened 10 years ago Closed 10 years ago

[VDR][Music] Apply Buttons and Input areas [BB]

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken)

Attachments

(1 file)

      No description provided.
Attached file patch for Gaia/master
Attachment #8404494 - Flags: feedback?(arnau)
Comment on attachment 8404494 [details] [review]
patch for Gaia/master

looks great!
please ask for r+ to a music app peer ;)
Attachment #8404494 - Flags: feedback?(arnau) → feedback+
Attachment #8404494 - Flags: review?(dflanagan)
Comment on attachment 8404494 [details] [review]
patch for Gaia/master

Forwarding the review request to Jim
Attachment #8404494 - Flags: review?(dflanagan) → review?(squibblyflabbetydoo)
Comment on attachment 8404494 [details] [review]
patch for Gaia/master

Code changes look good to me. I assume Arnau has tried out the patch; I'd try it myself, but I'm in the middle of moving across town.
Attachment #8404494 - Flags: review?(squibblyflabbetydoo) → review+
Thanks :) 

Landed in master:
https://github.com/pivanov/gaia/commit/dfe1a0f0451475c269593b52def3f32c835b2c6a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: