Closed
Bug 993168
Opened 12 years ago
Closed 12 years ago
Use recursive makeDir in the Windows app installer
Categories
(Firefox Graveyard :: Web Apps, defect)
Firefox Graveyard
Web Apps
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: marco, Assigned: marco)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
We are using a custom solution, we should employ the freshly introduced recursive makeDir.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8402980 -
Flags: review?(dteller)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8402980 [details] [diff] [review]
use_recursive_makeDir_in_apps_installer
Review of attachment 8402980 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #8402980 -
Flags: review?(dteller) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Do we have tests for the WebApps installer to make sure this change isn't regressing?
Flags: in-testsuite?
|
|
Assignee | |
Comment 6•11 years ago
|
||
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #5)
> Do we have tests for the WebApps installer to make sure this change isn't
> regressing?
Yes, under toolkit/webapps/tests/.
Flags: in-testsuite? → in-testsuite+
|
||
Updated•10 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•