Closed Bug 99319 Opened 21 years ago Closed 15 years ago

startup debug printf: "Note: styleverifytree is disabled", etc.

Categories

(Core :: Layout, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bstell, Assigned: sciguyryan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

is anyone actually looking at these startup messages?:

  Note: verifyreflow is disabled

or

  Note: styleverifytree is disabled

or

  Note: frameverifytree is disabled
Attached patch patch; disable the printfs (obsolete) — Splinter Review
Just remove the lines, rather than littering the file with commented-out code.
Do that, and r=waterson.
Status: NEW → ASSIGNED
Target Milestone: --- → Future
--> ftang
Assignee: bstell → ftang
Status: ASSIGNED → NEW
bulk move NEW FUTURE bug to ASSIGN
Status: NEW → ASSIGNED
Product: Browser → Seamonkey
-> to default owner
Assignee: ftang → general
Status: ASSIGNED → NEW
QA Contact: doronr → general
Blocks: fx-noise
Assignee: general → nobody
Component: General → Layout
Product: Mozilla Application Suite → Core
QA Contact: general → layout
Summary: startup debug printf → startup debug printf: "Note: styleverifytree is disabled", etc.
Target Milestone: Future → ---
Attached patch Patch v2.0 (obsolete) — Splinter Review
Patch v2.0

Not sure if this bug still applies or not but here is a patch to remove the printf's if they are no longer needed.
Assignee: nobody → sciguyryan
Attachment #49065 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #270878 - Flags: superreview?(bzbarsky)
Attachment #270878 - Flags: review?(bzbarsky)
Comment on attachment 270878 [details] [diff] [review]
Patch v2.0

Sure.
Attachment #270878 - Flags: superreview?(bzbarsky)
Attachment #270878 - Flags: superreview+
Attachment #270878 - Flags: review?(bzbarsky)
Attachment #270878 - Flags: review+
Can you kill "Note: verifyreflow is disabled" too?
Attached patch Patch v2.1 (obsolete) — Splinter Review
Patch v2.1

Now with verifyreflow removal!
Attachment #270878 - Attachment is obsolete: true
Attachment #271069 - Flags: superreview?(bzbarsky)
Attachment #271069 - Flags: review?(bzbarsky)
Comment on attachment 271069 [details] [diff] [review]
Patch v2.1

This I'm not happy with.  Instead, please make it so the printfs only happen when these things are enabled. In those cases they should indicate what exactly is enabled, as they do now.
Attachment #271069 - Flags: superreview?(bzbarsky)
Attachment #271069 - Flags: superreview-
Attachment #271069 - Flags: review?(bzbarsky)
Attachment #271069 - Flags: review-
That's assuming that the code is still relevant, of course.
Attached patch Patch v2.2Splinter Review
Patch v2.2

Only shows the verifyreflow printouts when its enabled.
Attachment #271069 - Attachment is obsolete: true
Attachment #271211 - Flags: superreview?(bzbarsky)
Attachment #271211 - Flags: review?(bzbarsky)
Comment on attachment 271211 [details] [diff] [review]
Patch v2.2

Looks good.  A diff -w would have really helped, though... ;)
Attachment #271211 - Flags: superreview?(bzbarsky)
Attachment #271211 - Flags: superreview+
Attachment #271211 - Flags: review?(bzbarsky)
Attachment #271211 - Flags: review+
Keywords: checkin-needed
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.