Closed Bug 993253 Opened 10 years ago Closed 10 years ago

Implement D3E InputEvent interface with isComposing


(Core :: DOM: Events, defect)

Not set





(Reporter: masayuki, Assigned: masayuki)



(Keywords: dev-doc-complete)


(1 file, 1 obsolete file)

D3E defines InputEvent interface. We should need to implement it.

Currently, we cannot support .data without refactoring nsEditor. However, it's easy to implement isComposing attribute.

So, let's implement only isComposing, first.
D3E defines InputEvent interface for "input" and "beforeinput".

This patch implements InputEvent and exposes it to web contents.

The initial InputEvent implementation only supports .isComposing.

> true if the input event occurs as part of a composition session, i.e., after a compositionstart event and before the corresponding compositionend event.
> The un-initialized value of this attribute MUST be false.

Implementing the other attribute, .data, needs more work in editor. Therefore, I'd like to implement only .isComposing first.

The internal event class is InternalEditorInputEvent since we already have WidgetInputEvent. So, InternalInputEvent isn't available with some macros.

InputEvent doesn't support document.createEvent() but supports ctor.

I'll request review to ehsan for the editor part.
Attachment #8403256 - Flags: review?(bugs)
Comment on attachment 8403256 [details] [diff] [review]
Implement DOM InputEvent interface with isComposing attribute

+  }
+  else {


} else {
Attachment #8403256 - Flags: review?(bugs) → review+
Rewriting the patch without creating nsIDOMInputEvent.
Attachment #8403256 - Attachment is obsolete: true
Attachment #8403825 - Flags: review?(bugs)
Attachment #8403825 - Flags: review?(bugs) → review+
Comment on attachment 8403825 [details] [diff] [review]
Implement DOM InputEvent interface with isComposing attribute


Could you review the editor part? "input" event has specific internal event, InternalEditorInputEvent, by this patch. Therefore, editor needs to dispatch input events with its instance. It needs to take isComposing which is true after compositionstart and compositionend. Therefore, the dispatcher needs to the state at constructing rather than at dispatching the event actually.
Attachment #8403825 - Flags: review?(ehsan)
Attachment #8403825 - Flags: review?(ehsan) → review+
Keywords: dev-doc-needed
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 998941
Depends on: 1027011
Oopps. Fixed thanks.
You need to log in before you can comment on or make changes to this bug.