Closed
Bug 1027011
Opened 11 years ago
Closed 11 years ago
TypeError in JavaScript code generated by dart2js in Firefox 31. Works in Firefox 30 and 32.
Categories
(Tech Evangelism Graveyard :: English US, defect)
Tracking
(firefox30 unaffected, firefox31- affected, firefox32- affected, firefox33- affected, firefox-esr24 unaffected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox30 | --- | unaffected |
firefox31 | - | affected |
firefox32 | - | affected |
firefox33 | - | affected |
firefox-esr24 | --- | unaffected |
People
(Reporter: stesch, Unassigned)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
38.35 KB,
application/x-zip
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140610163407
Steps to reproduce:
Trying to type into the input field for step 3 on https://www.dartlang.org/codelabs/darrrt/
("Step" as in "Step of the tutorial on the mentioned page.")
Actual results:
Nothing appears in the badge. Error on the console:
TypeError: J.getInterceptor$x(...).get$target is not a function piratebadge.dart.js:5650
--
Source: https://www.dartlang.org/codelabs/darrrt/examples/3-buttonbadge/piratebadge.dart.js
Expected results:
Entered text should appear in the badge. Works for step 2.
Source: https://www.dartlang.org/codelabs/darrrt/examples/2-inputnamebadge/piratebadge.dart.js
Reporter | ||
Updated•11 years ago
|
OS: Mac OS X → All
Reporter | ||
Comment 1•11 years ago
|
||
Reported for Dart, but seems to be a Firefox/JavaScript bug: https://code.google.com/p/dart/issues/detail?id=19489
Works in Firefox 30, Firefox 30 Mobile, Firefox 32 AURORA, Google Chrome, Safari, …
Only Firefox 31.0 Beta in the current version as of 2014-06-17 has this problem.
Comment 2•11 years ago
|
||
We should bisect this...
![]() |
||
Comment 3•11 years ago
|
||
![]() |
||
Comment 4•11 years ago
|
||
I can reproduce in Firefox Beta31b1, Aurora32.0a2 and Nightly33.0a1.
Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7699524771b1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140410000846
Bad;
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a2a1efffcd5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140410001244
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7699524771b1&tochange=8a2a1efffcd5
Regressed by: Bug 993253 , Bug 993234
Status: UNCONFIRMED → NEW
status-firefox30:
--- → unaffected
status-firefox31:
--- → affected
status-firefox32:
--- → affected
status-firefox33:
--- → affected
status-firefox-esr24:
--- → unaffected
tracking-firefox31:
--- → ?
tracking-firefox32:
--- → ?
tracking-firefox33:
--- → ?
Component: JavaScript Engine → DOM: Events
Ever confirmed: true
Keywords: regression
Comment 5•11 years ago
|
||
Thanks Alice! :)
Sounds like a web site bug, but perhaps there is something in D3E which isn't
fully backwards compatible?
Masayuki, could you take a look at this?
Flags: needinfo?(masayuki)
Comment 7•11 years ago
|
||
This is a bug of the generated (?) script.
> 5348: UIEvent: {"": "Event;", "%": "CompositionEvent|FocusEvent|KeyboardEvent|SVGZoomEvent|TextEvent|TouchEvent;UIEvent"},
This line looks like that it defines the subclasses of UIEvent. However, of course, this doesn't include InputEvent.
If I change this line as:
> UIEvent: {"": "Event;", "%": "CompositionEvent|FocusEvent|KeyboardEvent|SVGZoomEvent|TextEvent|TouchEvent|InputEvent;UIEvent"},
Then, the testcase works.
This should be invalid. Although, there might be a way to fix this on Gecko side or D3E side.
Flags: needinfo?(masayuki) → needinfo?(bugs)
Comment 8•11 years ago
|
||
I still don't understand well, looks like that the code maps the interfaces with their static database. So, when browser implements new interface, it perfectly becomes unknown type object. Therefore, I believe that this code is too delicate for living in current web. This should create the interface map from objects dynamically.
I pinged irc://freenode/dart about this issue.
Masayuki, could you tell about this to Gary Kacmarcik?
Flags: needinfo?(bugs)
Ah, sounds like dart team is fixing this
https://code.google.com/p/dart/issues/detail?id=19489#c7
Comment 11•11 years ago
|
||
Not tracking. Seems to be a dart issue.
Comment 12•11 years ago
|
||
Is this INVALID then?
(In reply to Olli Pettay [:smaug] from comment #9)
> Masayuki, could you tell about this to Gary Kacmarcik?
(ni? just to make sure this reaches you)
Flags: needinfo?(masayuki)
I asked in the dart bug about any news on fixing it.
But this looks like a evang bug.
Comment 14•11 years ago
|
||
I sent this issue to D3E WG members. Anyway, I think that dart2js should get event prototype name directly (window.InputEvent returns non-null value on Gecko).
Flags: needinfo?(masayuki)
Comment 15•11 years ago
|
||
Looks like this was fixed by dart2js.
https://code.google.com/p/dart/issues/detail?id=19489#c17
Marking this as INVA? or moving to tech evangelism and marking as FIXED?
Comment 16•11 years ago
|
||
I'll just go ahead here …
Assignee: nobody → english-us
Status: NEW → RESOLVED
Closed: 11 years ago
Component: DOM: Events → English US
Product: Core → Tech Evangelism
Resolution: --- → FIXED
Version: 31 Branch → Firefox 31
Updated•10 years ago
|
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•