993280 - [Bluetooth][Certification][PTS][Bluedroid][1.4] HFP TC_AG_ECS_BV_01_I

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: TC_AG_ECS_BV_01_I.zip

### ENV
Nexus 4/Bluedroid
https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-aurora-nexus-4/2014/03/2014-03-25-16-02-01/


### STR
1. PTS 5.0
2. TC_AG_ECS_BV_01_I & TC_AG_ECS_BV_03_I

### Expected
Pass 

### Actual
### TC_AG_ECS_BV_01_I 
Test case : TC_AG_ECS_BV_01_I started
	- SDP Service record for PTS: 'Handsfree HF' successfully registered
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- Using SDP to determine IUT RFCOMM server channel number.
	- ProtocolDescriptorList: IUT reports that its RFCOMM server channel number is 3
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: WARNING: IUT does not report support for AT+CHLD=3 in its +CHLD response, but TSPC_HFP_2_12c is set to TRUE
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- MTC: AT+CLCC
	- AT: +CLCC received: +CLCC: 1,1,1,0,0,"0986143883",129
	- AT: +CLCC received: +CLCC: 2,1,0,0,0,"0958028209",129
	- FATAL ERROR (MTC): Sending AT command from MTC to AT PTC timed out
	- FATAL ERROR (AT): The response to the following AT command has timed out: AT+CLCC
	- AT: SPP disconnect succeeded
	- MTC received unexpected EXIT message from AT component
Final Verdict : Inconclusive

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: TC_AG_ECS_BV_03_I.zip

### ENV
Nexus 4/Bluedroid
https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-aurora-nexus-4/2014/03/2014-03-25-16-02-01/


### STR
1. PTS 5.0
2. TC_AG_ECS_BV_01_I & TC_AG_ECS_BV_03_I

### Expected
Pass 

### Actual
### TC_AG_ECS_BV_03_I
Test case : TC_AG_ECS_BV_03_I started
	- SDP Service record for PTS: 'Handsfree HF' successfully registered
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: WARNING: IUT does not report support for AT+CHLD=3 in its +CHLD response, but TSPC_HFP_2_12c is set to TRUE
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- AT: RING
	- AT: Received +CLIP: "0986143883",129
	- HCI: Audio Connection enabled
	- AT: Incoming call established
	- FATAL ERROR (AT): +CIEV(callheld=1) received when there is no second call process
	- MTC received unexpected EXIT message from AT component
	- HCI: Audio Connection disabled
	- AT: SPP disconnect succeeded
	- MTC: Test case ended
Final Verdict : Inconclusive

Comment 2

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Patch1 Bug 993280: Respond OK to HF for AT+CLCC, AT+CHUP, AT+CHLD commands

Patch1 will fix TC_AG_ECS_BV_01_I by responding OK for AT+CLCC and AT+CHLD commands.
(This patch also adds a response for AT+CHUP command since it's a similar bug.)
TC_AG_ECS_BV_03_I has the same cause as HFP TC_AG_TWC_BV_01_I, will be fixed later in bug 993288.

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Patch1 Bug 993280: Respond OK to HF for AT+CLCC and AT+CHLD

Update the patch, no need to response OK in ProcessHangupCall().

Comment 5

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8406685 [details] [diff] [review]
Patch1 Bug 993280: Respond OK to HF for AT+CLCC and AT+CHLD

Review of attachment 8406685 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bluetooth/bluedroid/hfp/BluetoothHfpManager.cpp
@@ +701,5 @@
>      MOZ_ASSERT(i == 2);
>  
>      SendCLCC(mCdmaSecondCall, 2);
>    }
> +  SendResponse(BTHF_AT_RESPONSE_OK);

not-even-a-nit: personally I would prefer leaving a blank line in this case to separate "SendResponse(BTHF_AT_RESPONSE_OK)" and the logic above. Seems more clear to me. ;)

Comment 6

[Jocelyn Liu [:jocelyn] [:joliu]]

Merge TC_AG_ECS_BV_03_I into Bug993288

Comment 7

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [final] Patch1 Bug 993280: Respond OK to HF for AT+CLCC and AT+CHLD

try server: https://tbpl.mozilla.org/?tree=Try&rev=3680b7ad10f6

Comment 8

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/b0da440e329f

Comment 9

[Jocelyn Liu [:jocelyn] [:joliu]]

Set 1.4? as this bug fails bluetooth certification HFP test on bluedroid.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0da440e329f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a4772a021181

Comment 12

[Eric Chang [:ericcc] [:echang]]

### Build for verification
https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-aurora-nexus-4/2014/04/2014-04-28-00-02-06/