993315 - [Settings] refreshed selector button need some space

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia, defect)

Description

[[e-mail]]

Attachment: 2014-04-07-18-25-44.png

How to reproduce:

1. open settings > sound

The Alert `change` button is very close to `Other sounds`(next section title)

(See attachment)

reproduce rate: 100%

Expect:

Have proper space with next element.

Comment 1

[[e-mail]]

Carol, could you help find right person to provide proper space? (or if it's already defined in spec)

Comment 2

[Carol Huang [:Carol]]

Attachment: 2013-08-11-23-13-46.png

Hi Fred,
I wonder which version you're looking at. The screenshot I provided is what I have on my device which is running on 1.4 and I didn't see the same result.

Comment 3

[[e-mail]]

It's in 2014/4/9 master build

Comment 4

[Carol Huang [:Carol]]

Hi Arthur,
Here's a issue in Settings >Sound >Tones
The Alert `change` button is very close to `Other sounds`(next section title), 
need to add 1.2 rem height space for it.(please see attachment)

The situation is when the device has no phone function, the third option(Audible touch tones) will be removed). Then the space between section is incorrect.

Can you help on this? or please let me know who i can ni, thanks!!!:)

Comment 5

[Carol Huang [:Carol]]

Attachment: Sound_tone_revise.jpg

Comment 6

[[e-mail]]

since it's only shown in non-phone case, maybe we can move this into flatfish developer program

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: master_demo.png

Do we still have this problem ? I noticed that we did update the layout here for sound panel few months ago.

Carol, I think this bug should be marked as invalid instead ?

(BTW, I am sorry to ping you at wrong bug just now xD)

Comment 8

[Carol Huang [:Carol]]

Hey EJ,
yeah, I think we don's have the 'height problem' now. Thanks!

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Carol and all. Let's close this bug !