993324 - Upgrade to TokBox SDK v2.2

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

We're currently using 2.0, and 2.2 has recently been released so we should upgrade to that.

Comment 1

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Early tests with 2.2 break our call establishment workflow. Investigating.

Comment 2

[Mark Banner (:standard8)]

Attachment: Link to Github pull-request: https://github.com/mozilla/loop-client/pull/14

Simple update to use 2.2, whilst there's some API changes, none directly affect us in the short term, so we'll leave those out for now.

I had a few issues attempting to adapt to the new APIs, some of it may have been down to how I was trying to operate it, at this stage, it isn't important for us to switch to them.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8403265 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop-client/pull/14

Switching reviews as NiKo is picking this up.

Note that the SDK in shared is the straight 2.2 version, as the previous patch is no longer necessary.

The SDK remains in shared so that FF doesn't need to download it, and that it is in a private repo for now.

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8403265 [details] [review]
Link to Github pull-request: https://github.com/mozilla/loop-client/pull/14

The patch looks good to me.

Comment 5

[Mark Banner (:standard8)]

https://github.com/mozilla/loop-client/commit/fa79726d35178830822e4d861d97196f14f664a5
https://github.com/mozilla/loop-client/commit/1e53be1fff466052c751754f37d7eb5efa152f4d

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/projects/elm/rev/4a3993823895

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/4a3993823895

Comment 8

[u279076]

Please needinfo me if you think this bug needs QA testing.