993383 - A dialog window without title bar appears after pressing on some buttons for in-content preferences

Status: RESOLVED DUPLICATE of bug 1036815

(Firefox :: Settings UI, defect)

Description

[Camelia Badau [:cbadau], Desktop QA]

Attachment: MAC specific issue.png

Reproducible on the latest Beta (BuildID: 20140407135746)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0
Reproducible on the latest Aurora (BuildID: 20140407004002)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0
Reproducible on the latest Nightly (BuildID: 20140407030203) 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Firefox/31.0

Steps to reproduce: 
1. Open about:preferences.
2. Go to Privacy tab, on History section and select “Use custom history for history” option. Click on the “Exceptions” button(from “Accept cookies from sites” option) and on the “Show Cookies” button.
3.Go to Security tab and click on the “Exceptions” button(from “Warn me when sites try to install add-ons” and “Remember password for sites” options) and on the “Saved Passwords” button;  
4.Go to Advanced tab, on Network and click on the “Exceptions” button(from “Tell me when a websites asks to store data for offline use” option). 

Actual results: After steps #2,#3 and #4, a dialog window without title bar (close, minimize, maximize buttons + title) appears. The dialog window can’t be closed (see screenshot “MAC specific issue.PNG”)

Expected results: After steps #2, #3 and #4, a dialog window with title bar is correctly displayed. The dialog window can be closed, minimized, maximized. 

Notes: This issue is not a regression.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: inContentNoModalDialogs.patch

This was because modal=yes was used for this dialogs. Then OS X used a panel where no "Okay/Cancel" buttons are shown. I changed every dialog which is also not modal in Preferences window to resizable=yes. Now a normal dialog is used.

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8409342 [details] [diff] [review]
inContentNoModalDialogs.patch

Review of attachment 8409342 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is what we want, looks like this will make easy for the user to lose the window under the main browser window (let alone resize it to a broken size), that doesn't sound too nice for prefs.
Ideally those should be tab-modal dialogs or even better inline editors. Probably this should go through UX to figure whether they should be dialogs at all.
In the meanwhile, I wonder if you could use the other options available to openDialog to add a close button without changing the dialog to a non-modal one.

Comment 3

[Richard Marti (:Paenglab)]

This happens already now with the prefs in window with the same dialogs when you click on the prefs, the dialog is hidden by the browser window (tested under Windows with).

The inline dialog will be done in bug 752197, where I have a WIP patch for one dialog to show how it could look.

Comment 5

[Tim Nguyen :ntim]

With the new in-content dialogs, only the "Exceptions" button of the Network tab in the Advanced category is affected.
I'm going to dupe this to bug 1036815, as that bug will fix this one.
Matthew, can you take a look at bug 1036815 please ? We're shipping the in-content prefs in 38, so it'd be nice not to ship with this issue.

Comment 6

[Matthew N. [:MattN]]

I attached my WIP patch there if you want to finish it.