993498 - Hide browser tabs if the target doesn't expose actors for them

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

Currently we display an empty list on b2g devices/simulators.
That's misleading and looks broken,
it would be better to just hide the Browser tab list item if the target doesn't support this feature.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Hide browser tabs if target doesn't expose any

Comment 3

[Jukka Jylänki]

Wouldn't it be better to have the tab, and print a message there saying "Your device/browser/etc. doesn't support this for reason x/y/.., please do this/this is a todo", since if some platforms do support this and others don't, hiding the feature completely might make the user think that the whole App Manager does not have the feature at all?

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Hide browser tabs if target doesn't expose any

Paul, I kept the patch quite simple to be suggest it for uplift.
We originally introduced this feature in Fx30 (bug 912900),
hopefully Fx31 can still be improved.

(In reply to Jukka Jylänki from comment #3)
> Wouldn't it be better to have the tab, and print a message there saying
> "Your device/browser/etc. doesn't support this for reason x/y/.., please do
> this/this is a todo", since if some platforms do support this and others
> don't, hiding the feature completely might make the user think that the
> whole App Manager does not have the feature at all?

That makes sense, but given that a new UI for the app manager is coming,
I don't want to spend too much time on tweaking the current UI.
Paul, what is the behavior of the new UI regarding tabs?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Can you please post a Try link if you've got one? Thanks :)

Comment 6

[Alexandre Poirot [:ochameau]]

browser/devtools/app-manager/content/ files isn't covered by any test.
(Good news, we are soon going to switch to browser/devtools/webide/, which is covered by tests!)

Having said that I can easily push to try if you think that can catch some unexpected build breakage or something.

Comment 7

[Alexandre Poirot [:ochameau]]

https://tbpl.mozilla.org/?tree=Try&rev=aea5c1d5e039

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d1eacfc0b704

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1eacfc0b704