Update Mozilla 31 to use NSS 3.16.1 (once it's ready)

RESOLVED FIXED in Firefox 31

Status

()

defect
P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cviecco, Assigned: wtc)

Tracking

unspecified
mozilla32
Points:
---

Firefox Tracking Flags

(firefox31 fixed, firefox32 fixed)

Details

Attachments

(1 attachment)

Update Mozilla 31 to use NSS 3.16.1 (once it's ready)

Starting with beta 1 today.
Whiteboard: [leave open]
Camilo: I forgot to create the NSS_3_16_1_BETA2 tag yesterday,
so I pushed NSS_3_16_1_BETA2 to mozilla-inbound myself:
https://hg.mozilla.org/integration/mozilla-inbound/rev/949b53bb379c
I get:
...Executing: c++ -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wca
st-align -flto=4 -ffunction-sections -fdata-sections -march=native -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe 
-DNDEBUG -DTRIMMED -O3 -fomit-frame-pointer -o BadCertServer /var/tmp/moz-build-dir/security/manager/ssl/tests/unit/tlsserver/cmd/tmpaq1Xb1.list -lpthread -Wl,--hash-style=gn
u,--as-needed,--gc-sections,--icf=all,--icf-iterations=3 -Wl,-z,noexecstack -Wl,--build-id -Wl,-rpath-link,/var/tmp/moz-build-dir/dist/bin -Wl,-rpath-link,/usr/lib -L../../..
/../../../../dist/bin -L../../../../../../../dist/lib -L/var/tmp/moz-build-dir/dist/lib -lnspr4 -lplc4 -lplds4 -L../../../../../../../dist/bin -L../../../../../../../dist/lib
 -lcrmf -lsmime3 -lssl3 -lnss3 -lnssutil3 ../../../../../../../dist/lib/libmozalloc.so ../../../../../../pkix/test/lib/libpkixtestutil.a -Wl,--whole-archive ../../../../../..
/../dist/lib/libmozglue.a -Wl,--no-whole-archive -rdynamic -ldlmake[5]: *** [GenerateOCSPResponse] Error 1

/var/tmp/moz-build-dir/security/manager/ssl/tests/unit/tlsserver/cmd/tmpaq1Xb1.list:
    INPUT("BadCertServer.o")
    INPUT("../../../../../../pkix/Unified_cpp_security_pkix0.o")
    INPUT("../lib/Unified_cpp_unit_tlsserver_lib0.o")

c++: error: ../../../../../../pkix/test/lib/libpkixtestutil.a: No such file or directory
/var/tmp/mozilla-central/config/rules.mk:802: recipe for target 'BadCertServer' failed
make[5]: *** [BadCertServer] Error 1
Octoploid: it seems that libpkixtestutil.a wasn't built successfully.
Can you search in your build output log for "pkixtestutil.cpp" and
"libpkixtestutil.a"? That should tell us if pkixtestutil.cpp has
compilation errors. Thanks.
Octoploid: the build problem you ran into seems like bug 1001585.
Please try the patch in that bug.
Wan-Teh: Many thanks. The patch from bug 1001585 fixes the issue.
NSS_3_16_1_BETA3 pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9a6a378349a
Patch pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca5aed9f1c37
Assignee: nobody → wtc
Status: NEW → ASSIGNED
Attachment #8414870 - Flags: review?(kaie)
Attachment #8414870 - Flags: checkin+
Attachment #8414870 - Flags: review?(kaie) → review+
Comment on attachment 8414870 [details] [diff] [review]
Update to NSS_3_16_1_BETA4: disable the new Intel AES assembly code for Windows

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New x86 AES assembly code
enabled in this patchset on Apr. 28 morning:
https://hg.mozilla.org/mozilla-central/rev/d9a6a378349a

User impact if declined: Potential memory corruption on Windows
computers with Intel CPUs that support the AES-NI and AVX instructions.

Testing completed (on m-c, etc.): On mozilla-central since Apr. 30.

Risk to taking this patch (and alternatives if risky): None. This reverts
the problematic change.

String or IDL/UUID changes made by this patch: None
Attachment #8414870 - Flags: approval-mozilla-aurora?
Attachment #8414870 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Wan-Teh, can you have a look at bug 1005988. I'm wondering if *this* bug has caused that crash.
Flags: needinfo?(wtc)
Comment on attachment 8414870 [details] [diff] [review]
Update to NSS_3_16_1_BETA4: disable the new Intel AES assembly code for Windows

Anthony: yes, bug 1005988 will be fixed after I push this patch
to mozilla-aurora. I will do this today.
Flags: needinfo?(wtc)
Comment on attachment 8414870 [details] [diff] [review]
Update to NSS_3_16_1_BETA4: disable the new Intel AES assembly code for Windows

NSS_3_16_1_RTM and NSPR_4_10_5_RTM pushed to mozilla-aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/0e571cde7fec
NSS_3_16_1_RTM and NSPR_4_10_5_RTM pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5695a4f7ab7
OS: Linux → All
Priority: -- → P1
Hardware: x86_64 → All
Whiteboard: [leave open]
Target Milestone: --- → mozilla31
https://hg.mozilla.org/mozilla-central/rev/e5695a4f7ab7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla31 → mozilla32
You need to log in before you can comment on or make changes to this bug.