993677 - [B2G][Calendar] Multi-day event starting after 11 pm displays outside of borders in week and day view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot - Week View

Description:
If user creates an event that spans multiple days in the Calendar app, the event listing will appear outside of the table boundaries in week and day view when the event starts at 11:03 pm or later

Repro Steps:
1) Updated Buri to BuildID: 20140408000202
2) Launch calendar app
3) Create new event
3a) Set start time between 11:03 PM and 11:59 PM on any day 
3b) Set end time for any time and day after start time
4) Select "Done" to finish event creation and view event in Week view

Actual:
First day of event appears at least partially outside table boundaries in week or day view.

Expected:
Event is always displayed within table boundaries.

Environmental Variables:
Device: Buri v1.4 Mozilla RIL
BuildID: 20140408000202
Gaia: 26983f356ecb1bcf30e862d334b5de790071803e
Gecko: 70b076fc7558
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshots

Comment 1

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot - Day View

Comment 2

[Jason Smith [:jsmith]]

Pretty sure this is a regression.

Can we confirm this isn't happening on 1.3?

Comment 3

[Tony Nguyen]

Attachment: screenshot1.3

This issue does reproduce on the latest Buri v1.3 mozRIL BuildID: 20140409004002. To clarify, the screenshot that the reporter attached is representing the behavior from the STR in comment 0 for when an event has been set to start at 11:59 PM.

Gaia: 100a159af11281d965e9d70d0f3d3111a38775ee
Gecko: ea2a473b122f
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 4

[Jason Smith [:jsmith]]

Does this happen on 1.1?

Comment 5

[Josh Schmitt [Joshs]]

(In reply to Jason Smith [:jsmith] from comment #4)
> Does this happen on 1.1?

I was able to repro this issue on 1.1 Buri build

1.1 Environmental Variables:
Device: Buri 1.1 MOZ
BuildID: 20140331041208
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 170d87349060
Version: 18.0
Firmware Version: V1.2-device.cfg

Comment 6

[Preeti Raghunath(:Preeti)]

Misleading calendar. Hence 1.4+

Comment 7

[Evan Tseng [:evanxd]]

I could not reproduce this bug on the below build.

Device: Buri v1.4
Gaia: 8dff633372022723e2ebad17fe3c826436b3b258
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/bc14179fc49c
BuildID: 20140414000201
Version: 30.0a2

Comment 8

[Evan Tseng [:evanxd]]

Hi Brogan,
Could you reproduce the on the build at Comment 7 currently?

Comment 9

[Rachel Pribble [:rpribble]]

I am able to reproduce this issue on the Buri v1.4 MOZ ril.

Environmental Variables:
Device: Buri v1.4 MOZ ril
BuildID: 20140414000201
Gaia: 8dff633372022723e2ebad17fe3c826436b3b258
Gecko: bc14179fc49c
Version: 30.0a2
Firmware Version: v1.2-device.cfg

An event that starts at 11:20pm and ends the next day at 1:00am displays outside the table boundaries as seen in the original image attachments.

Comment 10

[Evan Tseng [:evanxd]]

We could reproduce the bug with follow Comment 9 currently.
Thanks, Rachel. :)

Comment 11

[Jason Smith [:jsmith]]

Renoming - we've already shipped with this in past releases.

Comment 12

[Evan Tseng [:evanxd]]

Attachment: WIP Pull request

Comment 13

[Evan Tseng [:evanxd]]

Attachment: event-view.png

Comment 14

[Evan Tseng [:evanxd]]

Attachment: week-view.png

Comment 15

[Evan Tseng [:evanxd]]

Attachment: day-view.png

Comment 16

[Evan Tseng [:evanxd]]

I think the week-view.png attachment and day-view.png attachment is what we want after we add a event like the event-view.png attachment.

But this bug might conflict with Bug 824835. Currently if the event is cross next day, the event element's height is fixed. So this bug is happened. See the logic at https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/views/day_based.js#L295-L305.

Comment 17

[Evan Tseng [:evanxd]]

Hi Harly,

For Comment 16, I think this bug is also about UX issue.
How do you think?

Thanks.

Comment 18

[Harly Hsu[:harly]]

I think for event that crosses to the next day, it is really strange to display event outside the border. The fix height of event element may need to be removed and display the actual height of the event from start to 12:00. Needinfo Miller as he has done some modifications to day/week view for visual refresh, which might be able to help on this.

Comment 19

[Miller Medeiros [:millermedeiros]]

I agree that expected behavior is what the image attachments show. On visual refresh the month view will have a different design (Bug 951069), which should bypass the problem shown on Bug 824835. And I also think that not showing the location is better than the bug it introduced. - if location is not displayed app doesn't look broken, most users won't even notice it.

PS: We need tests to avoid regressions (can be unit or integration). Maybe an integration test that checks if event is overflowing the "hour" would be enough.

Comment 20

[Evan Tseng [:evanxd]]

I think we could do this bug in the visual refresh works.

Comment 21

[Miller Medeiros [:millermedeiros]]

this was fixed on 2.0 and 2.1

Comment 22

[Miller Medeiros [:millermedeiros]]

my bad, this still happens for day view on 2.0 and 2.1 - it should be fixed as soon as we land Bug 1052960

Comment 23

[Dylan Oliver [:doliver]]

[priority] --> tracking-b2g:+ conversion

Comment 24

[Miller Medeiros [:millermedeiros]]

fixed on Day View together with Bug 1052960