1052960 - [Calendar] Day View: update it to use same logic as the 5-day week view

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

I wrote the 5-Day Week View as generic MultiDay/SingleDay views, so it should be fairly easy to reuse the same logic between week and day views (by just setting the amount of visible days to 1 and a couple extra overrides).

The main benefit of using the same logic is that the new WeekView is way simpler to understand (better separation of concerns, less inheritance, simpler DOM structure); it looks nicer since we have the drag and swipe animations; UX will be consistent; and many times we have bugs that we need to update in multiple views, those should be easier to fix with a shared codebase..

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24759#issuecomment-57821230

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

This looks awesome. We will have to do some updating after amd lands though...

Comment 3

[Dylan Oliver [:doliver]]

[priority] --> tracking-b2g:+ conversion

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8499740 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24759#issuecomment-57821230

LGTM! Nice work :)

Comment 5

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/365a18b1a2c7dac7af3c8cd7fdbf5de7fba79b41