993784 - Stop using Thebes surfaces for masking in BasicLayers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

This a subset of bug 989858, and is blocking jwatt's conversion of imgIContainer::GetFrame.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Using Moz2D mask data for BasicThebesLayer

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Add gfxContext API to avoid converting between moz2d and thebes needlessly

I guess this isn't ideal, but it's a lot easier than converting all of BasicLayers and lets us unblock jwatt's work. This can go away again once all the things are done.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Switch to Moz2d for masking

We're already requiring Moz2D backed gfxContexts for BasicLayers. This just avoids converting our Moz2D surface into a thebes one and then back again.

Comment 4

[Matt Woodrow (:mattwoodrow)]

Attachment: Remove all the dead code

And this removes the last user of the 'deprecated' surfaces on Image, which makes the world a happier place.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8403684 [details] [diff] [review]
Add gfxContext API to avoid converting between moz2d and thebes needlessly

Review of attachment 8403684 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxContext.cpp
@@ +1514,5 @@
>  
>      if (!sourceSurf) {
>        return;
>      }
> +  

trailing whitespace

@@ +1528,5 @@
> +  MOZ_ASSERT(mDT);
> +
> +
> +  // We clip here to bind to the mask surface bounds, see above.
> +  mDT->MaskSurface(GeneralPattern(this), 

trailing whitespace

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/398f17d079cf
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c1fc4eed0f5
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a2528da6fe8
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3f9e19fa94

Comment 7

[Gary [:streetwolf52]]

After installing this patch on inbound I get massive graphic corruption when I scroll.  I did a regression test and narrowed it down to this patch.

I'm running Windows 8.1.1.

Comment 8

[Gary [:streetwolf52]]

Graphics
--------

Adapter Description: AMD Radeon HD 7900 Series
Adapter Drivers: aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64
Adapter RAM: 3072
Device ID: 0x6798
Direct2D Enabled: true
DirectWrite Enabled: true (6.3.9600.16384)
Driver Date: 12-6-2013
Driver Version: 13.251.0.0
GPU #2 Active: false
GPU Accelerated Windows: 1/1 Direct3D 11 (OMTC)
Vendor ID: 0x1002
WebGL Renderer: Google Inc. -- ANGLE (AMD Radeon HD 7900 Series Direct3D9Ex vs_3_0 ps_3_0)
windowLayerManagerRemote: true
AzureCanvasBackend: direct2d
AzureContentBackend: direct2d
AzureFallbackCanvasBackend: cairo
AzureSkiaAccelerated: 0

Comment 9

[Gary [:streetwolf52]]

Turning off HWA produces no corruption.

Comment 10

[Gary [:streetwolf52]]

Attachment: Corruption

Comment 11

[Gary [:streetwolf52]]

FYI... Left HWA enabled and turned off OMTC and there is no corruption.

Comment 12

[Gary [:streetwolf52]]

Any confirmation of my findings?

Comment 13

[Matt Woodrow (:mattwoodrow)]

Are you sure it's this bug? I strongly suspect you're seeing something related to Bug 992486 (which landed at the same time).

Comment 14

[Gary [:streetwolf52]]

I could only find this patch when I did my regression testing using the inbounds.  I can't find the files that contain 992486.  Is there a separate file that contains 992486 and not 993784?

Comment 15

[Matt Woodrow (:mattwoodrow)]

No there isn't, sorry. I can have a look locally I guess.

Comment 16

[Gary [:streetwolf52]]

If the file I used on inbound contains both patches then it's a toss up as to which one is causing my problem. I'm just trying to prevent a bad patch from hitting Nightly.

Comment 17

[Matt Woodrow (:mattwoodrow)]

I reproduced this locally, it is indeed bug 992486. I'll fix it.

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/398f17d079cf
https://hg.mozilla.org/mozilla-central/rev/3c1fc4eed0f5
https://hg.mozilla.org/mozilla-central/rev/3a2528da6fe8
https://hg.mozilla.org/mozilla-central/rev/fb3f9e19fa94