960524 - Remove Image::DeprecatedGetAsSurface

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ali Ak]

Remove calls to Image::DeprecatedGetAsSurface and use Image::GetAsSourceSurface instead.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking this as NEW based on the conversation in bug 947194.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

The work in the various blocking bugs needs to be finished and then this should do the rest.

Comment 3

[Jonathan Watt [:jwatt]]

To land this the DeprecatedGetCurrentAsSurface() call in BasicImageLayer::GetAsSurface() needs to go away, which Matt is working on in bug 989858.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2b29dbe2ae9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2b29dbe2ae9

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

jonathan, in comment 3 you seem to be saying that bug 989858 needs to be fixed before this can land. But bug 989858 isn't fixed and got untracked for 31.    Is this OK to go into 31?  

Is there any way I can test or verify this fix?  Thanks !

Comment 8

[Jonathan Watt [:jwatt]]

(In reply to Liz Henry :lizzard from comment #7)
> Is there any way I can test or verify this fix?  Thanks !

There's no reason to uplift this bugs patch, and it doesn't need qa attention. Thanks.

Comment 9

[u279076]

qa- as per comment 8.