Closed Bug 960524 Opened 7 years ago Closed 6 years ago

Remove Image::DeprecatedGetAsSurface

Categories

(Core :: Graphics: Layers, defect)

31 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox31 --- fixed

People

(Reporter: ali, Assigned: jwatt)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

Remove calls to Image::DeprecatedGetAsSurface and use Image::GetAsSourceSurface instead.
Blocks: 947194
Depends on: 959121, 959120
Depends on: 964731
Depends on: 964732
Depends on: 972843
Marking this as NEW based on the conversation in bug 947194.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Depends on: 982395
Depends on: 982419
Depends on: 982427
Depends on: 990752
Attached patch patch (obsolete) — Splinter Review
The work in the various blocking bugs needs to be finished and then this should do the rest.
To land this the DeprecatedGetCurrentAsSurface() call in BasicImageLayer::GetAsSurface() needs to go away, which Matt is working on in bug 989858.
Depends on: 989858
Attached patch patchSplinter Review
Attachment #8400703 - Flags: review?(matt.woodrow)
Attachment #8400230 - Attachment is obsolete: true
Blocks: 950372
Attachment #8400703 - Flags: review?(matt.woodrow) → review+
Depends on: 993784
No longer depends on: 989858
Summary: [meta] Remove Image::DeprecatedGetAsSurface → Remove Image::DeprecatedGetAsSurface
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2b29dbe2ae9
OS: Mac OS X → All
Hardware: x86 → All
Version: 28 Branch → 31 Branch
https://hg.mozilla.org/mozilla-central/rev/f2b29dbe2ae9
Assignee: nobody → jwatt
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
jonathan, in comment 3 you seem to be saying that bug 989858 needs to be fixed before this can land. But bug 989858 isn't fixed and got untracked for 31.    Is this OK to go into 31?  

Is there any way I can test or verify this fix?  Thanks !
Flags: needinfo?(jwatt)
(In reply to Liz Henry :lizzard from comment #7)
> Is there any way I can test or verify this fix?  Thanks !

There's no reason to uplift this bugs patch, and it doesn't need qa attention. Thanks.
Flags: needinfo?(jwatt)
qa- as per comment 8.
QA Whiteboard: [qa-]
Whiteboard: [qa?]
Depends on: 1440038
You need to log in before you can comment on or make changes to this bug.