993794 - FxA Settings app: Remove code that checks if FxA is preffed off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect, P2)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Same thing as bug 983452 - since firefox accounts is shipping in 1.5, let's pull out the unneeded code which checks if it's disabled.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

per discussion in bug 967783, maybe we want to promote this to blocker?

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I was incorrect in c1: bug 996476 is the bug that discusses problems with OTA updates and this pref.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 19507

Hi Arthur and Francisco,

Do you guys have time for a small review? This patch removes the pref that disabled FxA, plus code that looks for that pref.

More details:

We preffed off FxA for the 1.4 release, and when it was preffed on, it turned out that OTA updates didn't catch the pref change (bug 996476). Since we don't plan to disable FxA again, the best solution seems to be removing the code that checks for the pref.

FTU and Settings are separately impacted, but if I remove (say) the FTU pref-checking code and delete the pref, then the Settings marionette test will fail. Rather than 3 PRs (one for FTU, one for Settings, one to finally remove the pref), I'm opting for one PR with multiple reviewers.

We're getting a bit close to the wire, so if you're too busy to take this review, please let me know who would be a good alternate, and I'll r? them instead.

Thank you!

Jared

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8427826 [details] [review]
Github PR 19507

r=me for the settings part, thanks.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8427826 [details] [review]
Github PR 19507

FTU part looking good to me.

One thing, this is just curiosity, was thinking about dead settings keys. From people upgrading from 1.4 -> 1.5 we will be leaving that key. Not that is an important thing since we don't use the key, but was just figuring out if we have a global mechanism to remove those dead keys.

Cheers,
F.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks for the reviews, guys!

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #6)
> One thing, this is just curiosity, was thinking about dead settings keys.
> From people upgrading from 1.4 -> 1.5 we will be leaving that key. Not that
> is an important thing since we don't use the key, but was just figuring out
> if we have a global mechanism to remove those dead keys.

Great question. I've seen a lot of bugs related to FOTA problems, but I haven't found a canonical bug related to updates of global settings.

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Master: https://github.com/mozilla-b2g/gaia/commit/02026a5f7a2703990de8e46048d245f71f217123