993920 - Collapse/Expand all comments button not working

Status: RESOLVED DUPLICATE of bug 974411

(Bugzilla :: User Interface, defect)

Description

[Acho Arnold (:bePolite)]

When I click on Collapse/Expand all comments, I get some javascript errors

>TypeError: Cannot set property 'innerHTML' of null
on  Like 54 of js/comments.js:54
>>link.innerHTML = "[+]";

Comment 2

[Frédéric Buclin]

This is a regression due to bug 40896. The culprit is this line:

  <pre id="comment_preview_text" class="bz_comment_text"></pre>

toggle_all_comments() calls

  var comments = YAHOO.util.Dom.getElementsByClassName('bz_comment_text');

to get all comments to collapse, but the line above introduced a field with an id which doesn't contain an integer, making the JS code to fail as all comments were supposed to have an integer in their id, of the form:

  var link = document.getElementById('comment_link_' + id);