993946 - B2G NFC: Consistent naming between Nfc or NFC in WebIDL

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

This is also mentioned by Hsinyi.
In WebIDL, some NFC objects are named with NFC (all letters capitalized), such as MozNFCTag, MozNFCPeer,

However others are using camelCase style, such as MozNfc, MozNfcManager, with only N is capitalized.

I think at least we should have consistent naming in WebIDL.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8413670 [details] [diff] [review]
Patch

Please don't copy, but rename. That way hg blame isn't lost.

Don't we still have navigator.mozNfc ? Should we change that too?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Patch v2.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

(In reply to Olli Pettay [:smaug] from comment #2)
> Please don't copy, but rename. That way hg blame isn't lost.
> 
Sorry, fix now.

> Don't we still have navigator.mozNfc ? Should we change that too?

mozNfc is the property, and W3C [1] also uses lower case 'nfc', I think it's okay for that.

The things I'd like to fix in this bug is the consistent naming between

 {MozNfc, MozNfcManager} and {MozNFCTag, MozNFCPeer}


[1] : http://w3c.github.io/nfc/proposals/common/nfc.html


thanks

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Try : https://tbpl.mozilla.org/?tree=Try&rev=028bb4f9500b


https://hg.mozilla.org/integration/b2g-inbound/rev/3b3f23c1df74

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3b3f23c1df74

Comment 7

[Garner Lee]

Hmm...I was wondering why the unit test cases were still working. W3C: navigator.nfc, ours eventually: navigator.Nfc (chopping moz off), currently in WebIDL: mapped to mozNfc, using MozNFC using:

JSImplementation="@mozilla.org/navigatorNfc;1",
NavigatorProperty="mozNfc")

to the definition in nsNfc.js.

What should our future migration plans be, for web content (and the nfc webapps)? (I can open a new bug as necessary).