Closed
Bug 993949
Opened 11 years ago
Closed 11 years ago
[Cost Control] Follow up to add unit test for bug 986358
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
1.4 S6 (25apr)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: salva, Assigned: mai)
References
Details
Attachments
(1 file)
We landed bug 986358 without tests. This bug aims to solve that issue.
|
Assignee | |
Comment 1•11 years ago
|
||
Hi,
Could you review the patch? I've to put some custom events on mocked methods to check the behaviour of the widget.
I can't think of any other way to do it, WDYT?
Regards
Attachment #8404642 -
Flags: review?(salva)
Attachment #8404642 -
Flags: feedback?(anthony)
|
||
Updated•11 years ago
|
Attachment #8404642 -
Flags: feedback?(anthony)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8404642 [details] [review]
test for previous patch
Comments on GitHub, summarizing: reduce noise by not introducing main application tests and expose a function to ease the testing. Ask for my review when you're done again. Thank you very much Mai.
Attachment #8404642 -
Flags: review?(salva)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8404642 [details] [review]
test for previous patch
Update the PR with your comments. Salva, could you review again?
Attachment #8404642 -
Flags: review?(salva)
|
|
Reporter | |
Comment 4•11 years ago
|
||
Comment on attachment 8404642 [details] [review]
test for previous patch
A couple of nits on GitHub. Now we have infrastructure to test the Widget! good work, Marina.
Attachment #8404642 -
Flags: review?(salva) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Master: ed9fea4a543c86bd71e803c4ef961c85f7f8929c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
status-b2g-v2.0:
--- → fixed
Target Milestone: --- → 1.4 S6 (25apr)
|
||
Updated•11 years ago
|
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•