994667 - Follow up of bug 986359 - Possible race condition when the icc is loaded

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

After talking with a back-end engineer, we discover that is possible the following scenario that currently is not covered on the CC app:

After a startup, it's possible that the mozMobileConnections api has correctly loaded the iccId but the iccManager api has not loaded the MozIcc object yet. For this reason, the following method IccManager.getIccById could returning a null object during a short time. 

To prevent unexpected errors, it's necessary to cover this scenario.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Ray, 
do you mind checking if this patch fix the error that you've reported on the Bug 986358 ([Sora][IOT]"Not SIM inserted message" appears when SIM is alrady inserted)? 

Regards

Comment 2

[Ray REN]

Dear marina,

The patch doesn't works well. I checked, when it happend, the "Common.dataSimIcc" is not null.

Comment 3

[Marina Rodríguez [:mai]]

Hi Ray,
do you mind checking the new patch again?
Regards

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8404704 [details] [review]
patch v1.0

Please, attend the comments on GitHub and tell me what happen when calling `loadDataSIMIccId` and it goes to `onerror` path?

Comment 5

[Marina Rodríguez [:mai]]

this scenario is impossible to reproduce it.