994511 - [Settings] move Settings.getSettings out of Settings.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

For load time improvement,

We could move SettingsCache and Settings.getSettings out of Settings.js.

Current dependency files: call, call_voicemail_settings, firefox_accounts/menu_loader, media_storage, storage

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8405982 [details] [review]
patch on master

Hi Fred,

can you give me some feedbacks about this change ? Thanks :)

(BTW, I only added require() to wrap original functions and it makes the diff huge , so please don't be scared.)

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

And also, because my developing env is a little bit broken, can you help me test the performance with command `make test-perf APP=settings` ? Thanks !!

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I just did `b2gperf --delay=10 Settings` twice and got the performance result : 

[perf 1]
2014-04-14 15:53:56,534 B2GPerfRunner INFO    | Results for Settings, cold_load_time: median:1783, mean:1792, std: 43, max:1991, min:1750, all:1892,1784,1776,1783,1763,1991,1807,1784,1768,1788,1769,1793,1774,1757,1797,1797,1750,1796,1777,1775,1780,1780,1777,1793,1806,1783,1789,1801,1769,1787

[perf 2]
2014-04-14 16:03:41,563 B2GPerfRunner INFO    | Results for Settings, cold_load_time: median:1794, mean:1793, std: 26, max:1869, min:1710, all:1832,1869,1817,1797,1770,1805,1800,1822,1784,1788,1794,1808,1710,1768,1773,1791,1818,1805,1799,1783,1784,1797,1774,1758,1795,1818,1783,1788,1802,1778

Comment 5

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #4)
> I just did `b2gperf --delay=10 Settings` twice and got the performance
> result : 
Attach my device information :

Gaia      44a77bf2177f84bb37ce858ed9c59de6a1c6db43
Gecko     https://hg.mozilla.org/mozilla-central/rev/83ae54e18689
BuildID   20140410160203
Version   31.0a1
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 6

[[e-mail]]

Comment on attachment 8405982 [details] [review]
patch on master

please see comments in github

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8405982 [details] [review]
patch on master

Addressed Fred's comments !

I think this patch is ready to review :)

thx

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8405982 [details] [review]
patch on master

Fred & Arthur, 

can you guys help me review this again !? Thanks !

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8405982 [details] [review]
patch on master

Thanks for the patch. r=me with the comments addressed.

Comment 10

[[e-mail]]

Comment on attachment 8405982 [details] [review]
patch on master

looks good to me. Thanks EJ. arthur+ is sufficient :)

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

ok thx Arthur & Fred. I would merge my code !

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Merged on Gaia/master : 0de0bf896422b5da5df7e57a570d72da662425db

Thanks all !!!