994582 - [UX] Tweak panel animation so that it looks good on all platforms/systems

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Alice0775 White]

See screen capture: http://youtu.be/duPd-7Ujbbw
An afterimage is obstructive.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Well, that's not good.
I also noticed some rather big differences in how the new animation feels on different platforms and system configurations.
Let's use this bug to find a solution to that problem (since that would also fix your original issue)

Comment 2

[Mike Hoye [:mhoye]]

Following the triage meetings, this remains unassigned. Philipp, would you be willing to mentor a community member through this bug?

Comment 3

[Tim Nguyen :ntim]

I think we should avoid any kind of hardware acceleration use. If we use some, we should give users the ability to disable the animation.

Comment 4

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Mike Hoye [:mhoye] from comment #2)
> Following the triage meetings, this remains unassigned. Philipp, would you
> be willing to mentor a community member through this bug?

Absolutely!

(In reply to Tim Nguyen [:ntim] from comment #3)
> I think we should avoid any kind of hardware acceleration use. If we use
> some, we should give users the ability to disable the animation.

Why should we avoid hardware acceleration? Are you concerned about compatibility?

Comment 5

[Tim Nguyen :ntim]

(In reply to Philipp Sackl [:phlsa] (on PTO Apr 16-23) from comment #4)
> (In reply to Mike Hoye [:mhoye] from comment #2)
> > Following the triage meetings, this remains unassigned. Philipp, would you
> > be willing to mentor a community member through this bug?
> 
> Absolutely!
> 
> (In reply to Tim Nguyen [:ntim] from comment #3)
> > I think we should avoid any kind of hardware acceleration use. If we use
> > some, we should give users the ability to disable the animation.
> 
> Why should we avoid hardware acceleration? Are you concerned about
> compatibility?

Yes, hardware acceleration can be slow on old computers. The ubuntu screencast shows what it can look like.

Comment 6

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Tim Nguyen [:ntim] from comment #5)
> (In reply to Philipp Sackl [:phlsa] (on PTO Apr 16-23) from comment #4)
> > (In reply to Mike Hoye [:mhoye] from comment #2)
> > > Following the triage meetings, this remains unassigned. Philipp, would you
> > > be willing to mentor a community member through this bug?
> > 
> > Absolutely!
> > 
> > (In reply to Tim Nguyen [:ntim] from comment #3)
> > > I think we should avoid any kind of hardware acceleration use. If we use
> > > some, we should give users the ability to disable the animation.
> > 
> > Why should we avoid hardware acceleration? Are you concerned about
> > compatibility?
> 
> Yes, hardware acceleration can be slow on old computers. The ubuntu
> screencast shows what it can look like.

Hm, so are you seeing the same effects when a website uses animated CSS transforms? AFAIK those are accelerated as well. I always thought that those animations would degrade by just skipping the animation entirely.

Comment 7

[Dão Gottwald [:dao]]

This discussion on hardware acceleration appears to be a red herring. There's no proof that the artifacts seen on Ubuntu are due to hardware acceleration. Even if they were, there's not much we could do about it, since this is controlled by the operating system's window manager.

Comment 9

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Patch v1

This patch implements a less jarring close animation and also tweaks the opening animation. Since no more shrinking is involved, it might also help with the after-image issues.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This is bitrotted. Please rebase.

Comment 11

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Patch v1.1 (r=enndeakin)

De-bitrotted. Carrying forward r+ by Neil.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/7f23305ed404

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7f23305ed404

Comment 14

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8421636 [details] [diff] [review]
Patch v1.1 (r=enndeakin)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 610545
User impact if declined: Users will see a less-than-optimal animation every time they close an arrowpanel. This animation also caused rendering glitches on some platforms.
Testing completed (on m-c, etc.): On Nightly for a week
Risk to taking this patch (and alternatives if risky): low, because it is only CSS adjustments
String or IDL/UUID changes made by this patch: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/875e084aa158