Closed
Bug 994601
Opened 11 years ago
Closed 11 years ago
Failed to build Flatfish, undefined 'RequestSettingValue' and 'nsIRILNetworkInterface'
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
(Whiteboard: [ft:ril][p=1])
Attachments
(1 file, 1 obsolete file)
|
6.15 KB,
patch
|
kanru
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #978709 comment 125 +++
Bug 978709 and bug 989692 fails Flatfish build.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → vyang
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [ft:ril][p=1]
Target Milestone: --- → 1.4 S6 (25apr)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Two things lead to FTBFS here:
1) bug 989692 added an debug setting through Settings API. However, nsISettingsCallback is only implemented when MOZ_B2G_RIL is true. Since Flatfish has now RIL functions, Settings related methods are not available in this case. => always implement nsISettingsCallback
2) bug 978709 deprecated the use of nsIRilDataCallback and replaced that with an observer event. => guard RIL related bits in GonkGPSGeolocationProvider::Observe().
Trying Mwn: https://tbpl.mozilla.org/?tree=Try&rev=f502d6b3b312
Attachment #8404625 -
Attachment is obsolete: true
Attachment #8405279 -
Flags: review?(kchen)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8405279 [details] [diff] [review]
bug-994601-flatfish-build-fail-gps.patch
Review of attachment 8405279 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8405279 -
Flags: review?(kchen) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 1.4 S6 (25apr) → 1.4 S5 (11apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•