994745 - [VDR][Wallpaper] Apply Buttons and Input areas [BB]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Wallpaper, defect)

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8404785 [details] [review]
patch for Gaia/master

You may want to ask the review to the app author :)

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh sorry ... I was not sure who is the author and I remember last time you give me r+ for the wallpapers :) so ... yeah Sorry :)

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8404785 [details] [review]
patch for Gaia/master

Forwarding the review to Jim.

Jim, I'm asking you to take this review on the theory that the wallpaper app is kind of like the ringtones app you're working on.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8404785 [details] [review]
patch for Gaia/master

Pavel, could you please add in share.html id="set-wallpaper", class="recommend"?
This way would have more contrast with cancel button.
LGTM :)

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Done :)

Comment 7

[Jim Porter (:squib)]

Comment on attachment 8404785 [details] [review]
patch for Gaia/master

Code changes seem good to me, so assuming Arnau's happy with the visuals, I'm happy too!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yey :) Thanks

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/341bb57b196f94cdb4cb91f9bce1352fe50565b1