995070 - Support draft-nottingham-safe-hint-01

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Doug Turner (:dougt)]

"""
Many Web sites have a "safe" mode, to assist those who don't want to
   be exposed to "objectionable" content, or who don't want their
   children to be exposed to such content.  YouTube [youtube], Yahoo!
   Search [yahoo], Google Search [google], Bing Search [bing], and many
   other services have such a setting.
"""

It sounds like these providers will be honoring such a setting.  We should provide a reasonable way to enable users to express their choice.

I suspect there are a couple action items:


1) create a pref that controls if necko sets this header.
2) add a checkbox to preferences if Firefox to toggle this preference
3) add a option in Firefox for Android to goggle this preference.
4) add a setting in FirefoxOS to toggle this setting

Comment 1

[Doug Turner (:dougt)]

Attachment: Part 1 - networking changes

Comment 2

[Doug Turner (:dougt)]

Attachment: patch 2 - firefox advance preferences checkbox

Comment 3

[Doug Turner (:dougt)]

Attachment: Screenshot of patch 2 on Firefox Mac

Comment 4

[Doug Turner (:dougt)]

Attachment: Screenshot showing that the preference is being sent

Comment 5

[Doug Turner (:dougt)]

5) we are going to want to also adjust the help content that is linked to from this dialog

Comment 6

[Patrick McManus [:mcmanus]]

Comment on attachment 8405168 [details] [diff] [review]
Part 1 - networking changes

Review of attachment 8405168 [details] [diff] [review]:
-----------------------------------------------------------------

the big questions here aren't really networking questions any more than they are for DNT.. but doug you're on the hook for tracking changes to this draft or prefer

::: netwerk/protocol/http/nsHttpHandler.h
@@ +434,5 @@
>      bool           mDoNotTrackEnabled;
>      uint8_t        mDoNotTrackValue;
>  
> +    // for broadcasting safe hint;
> +    bool           mSafeHintEnabled;

nit - save a byte with uint32_t : 1 (merged into bit field below it)

Comment 7

[Doug Turner (:dougt)]

Comment on attachment 8405168 [details] [diff] [review]
Part 1 - networking changes

Review of attachment 8405168 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpHandler.h
@@ +434,5 @@
>      bool           mDoNotTrackEnabled;
>      uint8_t        mDoNotTrackValue;
>  
> +    // for broadcasting safe hint;
> +    bool           mSafeHintEnabled;

same as mDoNotTrackEnabled?

Comment 8

[Doug Turner (:dougt)]

> the big questions here aren't really networking questions any more than they are for DNT.. but doug you're on the hook for tracking changes to this draft or prefer

Yup.  Lets land the platform bits independent of the UI.  I want to ensure addons can toggle this.

Comment 9

[Doug Turner (:dougt)]

removing firefox ui bits.

Comment 10

[Patrick McManus [:mcmanus]]

Comment on attachment 8405168 [details] [diff] [review]
Part 1 - networking changes

Review of attachment 8405168 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpHandler.h
@@ +434,5 @@
>      bool           mDoNotTrackEnabled;
>      uint8_t        mDoNotTrackValue;
>  
> +    // for broadcasting safe hint;
> +    bool           mSafeHintEnabled;

but different than the superior mTelemetryEnabled :)

totally not impt.

Comment 11

[Patrick McManus [:mcmanus]]

Comment on attachment 8405168 [details] [diff] [review]
Part 1 - networking changes

Review of attachment 8405168 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpHandler.cpp
@@ +421,5 @@
>      }
>  
> +    // add the "Send Hint" header
> +    if (mSafeHintEnabled) {
> +      rv = request->SetHeader(nsHttp::Prefer, nsDependentCString("safe"));

NS_LITERAL_CSTRING("safe") ?

Comment 12

[Doug Turner (:dougt)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/4f42a748cfaa

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4f42a748cfaa