995430 - send header when user is signed into a children's account

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Comment 1

[Doug Turner (:dougt)]

Attachment: 338b9b10a5b5

Comment 2

[Doug Turner (:dougt)]

Didn't know about nsIParentalControlsService.  Works in windows 7 & 8.1.

Request without preference set in a 'child' account:
     https://www.dropbox.com/s/brqee0imcu74n4s/Screenshot%202014-05-04%2022.07.17.png

I'll create a follow up for a mac implementation.

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8417183 [details] [diff] [review]
338b9b10a5b5

Review of attachment 8417183 [details] [diff] [review]:
-----------------------------------------------------------------

This conflicts with the pref in a confusing way. you might just delete the pref?

this doesn't do dynamic config, which is probably ok give that it is windows account driven, just add a comment.

Comment 4

[Doug Turner (:dougt)]

Attachment: patch v.2

Comment 5

[Patrick McManus [:mcmanus]]

Comment on attachment 8418386 [details] [diff] [review]
patch v.2

Review of attachment 8418386 [details] [diff] [review]:
-----------------------------------------------------------------

if network.http.safeHint.enabled is set to any value (either true or false) that will override the parental controls service value. Is that what you want? I can see the argument going either way.

Comment 6

[Doug Turner (:dougt)]

Attachment: attachment.cgi?id=8418386

i think this is clearer to what I want.  We should send the header: If the user decides to set the preference OR if the user is using a child account.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Hey Doug, does this have a recent Try run?

Comment 8

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d0c1f1037e3

Comment 9

[Andreas Gal :gal]

This is a pretty trivial patch and we would like to use it for a time-sensitive campaign.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d0c1f1037e3

Comment 11

[Doug Turner (:dougt)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/765e85a7f291