Closed Bug 995430 Opened 6 years ago Closed 6 years ago

send header when user is signed into a children's account

Categories

(Core :: Networking: HTTP, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
firefox31 --- fixed
firefox32 --- fixed

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Summary: For 'safe' browsing hit on user accounts that parental protected. → send header when user is signed into a children's account
Attached patch 338b9b10a5b5 (obsolete) — Splinter Review
Attachment #8417183 - Flags: review?(mcmanus)
Didn't know about nsIParentalControlsService.  Works in windows 7 & 8.1.

Request without preference set in a 'child' account:
     https://www.dropbox.com/s/brqee0imcu74n4s/Screenshot%202014-05-04%2022.07.17.png

I'll create a follow up for a mac implementation.
Comment on attachment 8417183 [details] [diff] [review]
338b9b10a5b5

Review of attachment 8417183 [details] [diff] [review]:
-----------------------------------------------------------------

This conflicts with the pref in a confusing way. you might just delete the pref?

this doesn't do dynamic config, which is probably ok give that it is windows account driven, just add a comment.
Attachment #8417183 - Flags: review?(mcmanus)
Attached patch patch v.2 (obsolete) — Splinter Review
Attachment #8417183 - Attachment is obsolete: true
Attachment #8418386 - Flags: review?(mcmanus)
Comment on attachment 8418386 [details] [diff] [review]
patch v.2

Review of attachment 8418386 [details] [diff] [review]:
-----------------------------------------------------------------

if network.http.safeHint.enabled is set to any value (either true or false) that will override the parental controls service value. Is that what you want? I can see the argument going either way.
i think this is clearer to what I want.  We should send the header: If the user decides to set the preference OR if the user is using a child account.
Attachment #8418386 - Attachment is obsolete: true
Attachment #8418386 - Flags: review?(mcmanus)
Attachment #8418788 - Flags: review?(mcmanus)
Attachment #8418788 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
Hey Doug, does this have a recent Try run?
Keywords: checkin-needed
Attachment #8418788 - Flags: approval-mozilla-aurora?
This is a pretty trivial patch and we would like to use it for a time-sensitive campaign.
https://hg.mozilla.org/mozilla-central/rev/9d0c1f1037e3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Attachment #8418788 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.