Closed
Bug 995101
Opened 10 years ago
Closed 10 years ago
NFC: Don't use nfc-hardware-state-change event to enable/disable NFC.
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(tracking-b2g:backlog)
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [p=3])
Attachments
(2 files, 1 obsolete file)
This is a follow-up for Bug 970251. Right now nfc_manager in System app will use nfc-hardware-state-change to enable/disable NFC hardware. When Bug 970251 is landed we should use API to do that so we don't have to dispatch CustomEvent to do so.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → allstars.chh
Whiteboard: [p=3]
Target Milestone: --- → 1.4 S6 (25apr)
Assignee | ||
Comment 1•10 years ago
|
||
This patch is basically revert the patch from Bug 959109, with rebase on current m-c.
Assignee | ||
Updated•10 years ago
|
Attachment #8405992 -
Flags: review?(dlee)
Assignee | ||
Comment 2•10 years ago
|
||
I'll send r? when Bug 970251 is r+ed.
Updated•10 years ago
|
Attachment #8405992 -
Flags: review?(dlee) → review+
Updated•10 years ago
|
blocking-b2g: --- → backlog
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8405995 -
Attachment is obsolete: true
Attachment #8406613 -
Flags: review?(alive)
Comment 4•10 years ago
|
||
Comment on attachment 8406613 [details] [review] Pull Request The code looks fine but I prefer to have unit test.
Attachment #8406613 -
Flags: review?(alive)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8406613 [details] [review] Pull Request Gaia unit test added.
Attachment #8406613 -
Flags: review?(alive)
Comment 6•10 years ago
|
||
Comment on attachment 8406613 [details] [review] Pull Request Lint and integration test fails.
Attachment #8406613 -
Flags: review?(alive)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8406613 [details] [review] Pull Request Sorry for asking r? again, I've fixed the error and travis is green now.
Attachment #8406613 -
Flags: review?(alive)
Updated•10 years ago
|
Attachment #8406613 -
Flags: review?(alive) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/acc4913071402bb30f1a9f72a7c8733234a02967
Assignee | ||
Comment 9•10 years ago
|
||
gecko part : https://hg.mozilla.org/integration/b2g-inbound/rev/0c1f862f7b44
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0c1f862f7b44
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•