Closed Bug 995101 Opened 6 years ago Closed 6 years ago

NFC: Don't use nfc-hardware-state-change event to enable/disable NFC.

Categories

(Firefox OS Graveyard :: NFC, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
1.4 S6 (25apr)
tracking-b2g backlog

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [p=3])

Attachments

(2 files, 1 obsolete file)

This is a follow-up for Bug 970251.
Right now nfc_manager in System app will use nfc-hardware-state-change to enable/disable NFC hardware. 

When Bug 970251 is landed we should use API to do that so we don't have to dispatch CustomEvent to do so.
Assignee: nobody → allstars.chh
Whiteboard: [p=3]
Target Milestone: --- → 1.4 S6 (25apr)
Attached patch PatchSplinter Review
This patch is basically revert the patch from Bug 959109, with rebase on current m-c.
Attached file WIP Gaia Patch. (obsolete) —
I'll send r? when Bug 970251 is r+ed.
Attachment #8405992 - Flags: review?(dlee) → review+
blocking-b2g: --- → backlog
Attached file Pull Request
Attachment #8405995 - Attachment is obsolete: true
Attachment #8406613 - Flags: review?(alive)
Comment on attachment 8406613 [details] [review]
Pull Request

The code looks fine but I prefer to have unit test.
Attachment #8406613 - Flags: review?(alive)
Comment on attachment 8406613 [details] [review]
Pull Request

Gaia unit test added.
Attachment #8406613 - Flags: review?(alive)
Comment on attachment 8406613 [details] [review]
Pull Request

Lint and integration test fails.
Attachment #8406613 - Flags: review?(alive)
Comment on attachment 8406613 [details] [review]
Pull Request

Sorry for asking r? again,
I've fixed the error and travis is green now.
Attachment #8406613 - Flags: review?(alive)
Attachment #8406613 - Flags: review?(alive) → review+
https://hg.mozilla.org/mozilla-central/rev/0c1f862f7b44
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.