995101 - NFC: Don't use nfc-hardware-state-change event to enable/disable NFC.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

This is a follow-up for Bug 970251.
Right now nfc_manager in System app will use nfc-hardware-state-change to enable/disable NFC hardware. 

When Bug 970251 is landed we should use API to do that so we don't have to dispatch CustomEvent to do so.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Patch

This patch is basically revert the patch from Bug 959109, with rebase on current m-c.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: WIP Gaia Patch.

I'll send r? when Bug 970251 is r+ed.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Pull Request

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8406613 [details] [review]
Pull Request

The code looks fine but I prefer to have unit test.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Comment on attachment 8406613 [details] [review]
Pull Request

Gaia unit test added.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8406613 [details] [review]
Pull Request

Lint and integration test fails.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Comment on attachment 8406613 [details] [review]
Pull Request

Sorry for asking r? again,
I've fixed the error and travis is green now.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

https://github.com/mozilla-b2g/gaia/commit/acc4913071402bb30f1a9f72a7c8733234a02967

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

gecko part : https://hg.mozilla.org/integration/b2g-inbound/rev/0c1f862f7b44

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0c1f862f7b44