995489 - Generalize the AutoCompleteE10S.jsm a little bit

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

For bug 949617, I need to show an autocomplete popup with login manager entries. I was able to use the existing code with a few modifications.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v1

This patch stands alone. It'll be used by the patches in bug 949617

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Oh, and the change to nsFormAutoComplete.js was a typo I happened to notice while debugging.

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8405665 [details] [diff] [review]
Patch v1

Review of attachment 8405665 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/satchel/AutoCompleteE10S.jsm
@@ +116,5 @@
> +    return resultsArray;
> +  },
> +
> +  // This function is used by the login manager, which uses a single message
> +  // to fill in the autocomplete results.

nit: since you documented below which message makes the function |search| to be used, can you also mention which one is gonna cause |showPopupWithResults| to be used?

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2baf5c61cbf5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Something in this push made Android sadface. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f291b1b47c7

https://tbpl.mozilla.org/php/getParsedLog.php?id=42378026&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=42378331&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=42377296&tree=Mozilla-Inbound

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Take 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/4a6ff8b73d5c

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a6ff8b73d5c

Comment 8

[Carsten Book [:Tomcat]]

sorry had to back this out from mozilla-central (and so with the merge in the integration trees) in https://tbpl.mozilla.org/?rev=83f9b25520bf since one of this checkins seems to have caused Bug 1030663 which is a frequent test failure now

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb57f323afdc

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fb57f323afdc