Closed Bug 995901 Opened 6 years ago Closed 6 years ago

Rename nsICSSRuleList to mozilla::dom::CSSRuleList

Categories

(Core :: DOM: CSS Object Model, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: Ms2ger, Assigned: Agi)

References

Details

Attachments

(1 file, 2 obsolete files)

Followup for bug 995664.
I have no idea how the s-s checkbox got ticked. Can someone please unhide?
Group: core-security
Attached patch CCSRuleList.patch (obsolete) — Splinter Review
Is there anything else that needs to be done?

Thanks!
Attachment #8436403 - Flags: review?(Ms2ger)
Comment on attachment 8436403 [details] [diff] [review]
CCSRuleList.patch

Review of attachment 8436403 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! Please fix these nits and ask :bz to review.

::: dom/bindings/Bindings.conf
@@ +259,5 @@
>  },
>  
>  'CSSRuleList': {
> +    'nativeType': 'mozilla::dom::CSSRuleList',
> +    'headerFile': 'CSSRuleList.h',

This entire block can go now.

::: layout/style/CSSRuleList.cpp
@@ +3,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#include "CSSRuleList.h"

#include "mozilla/dom/CSSRuleList.h"

@@ +28,2 @@
>  {
>    return dom::CSSRuleListBinding::Wrap(aCx, this);

Drop the dom:: here

::: layout/style/CSSRuleList.h
@@ +2,5 @@
>  /* This Source Code Form is subject to the terms of the Mozilla Public
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
> +#ifndef CSSRuleList_h

mozilla_dom_CSSRuleList_h

::: layout/style/nsCSSRules.cpp
@@ +21,5 @@
>  
>  #include "nsCOMPtr.h"
>  #include "nsIDOMCSSStyleSheet.h"
>  #include "nsIMediaList.h"
> +#include "CSSRuleList.h"

mozilla/dom/; also elsewhere
Attachment #8436403 - Flags: review?(Ms2ger) → feedback+
Thanks for the review Ms2ger! I addressed your nits.

Thanks!
Attachment #8436403 - Attachment is obsolete: true
Attachment #8436490 - Flags: review?(bzbarsky)
Comment on attachment 8436490 [details] [diff] [review]
Rename nsICSSRuleList to mozilla::dom::CSSRuleList

>+using namespace mozilla::dom;

We should be putting the relevant parts of this file in the mozilla::dom namespace instead, no?

r=me with that fixed.  Thank you for the patch!
Attachment #8436490 - Flags: review?(bzbarsky) → review+
> We should be putting the relevant parts of this file in the mozilla::dom namespace instead, no?

Err, sure. Fixed, carrying over the r+. Thanks bz!
Assignee: nobody → agi.novanta
Attachment #8436490 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8437442 - Flags: review+
Keywords: checkin-needed
Do you have a Try link handy for this by chance?
Keywords: checkin-needed
Yeah sorry I forgot to post it https://tbpl.mozilla.org/?tree=Try&rev=85d8b38b9acb

It's the version that bz reviewed.
https://hg.mozilla.org/mozilla-central/rev/ddc9fdfcc8b6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.