Closed
Bug 995995
Opened 10 years ago
Closed 10 years ago
browser/base/content/test/general/test_bug364677.html connects to yahoo everytime (browser/components/feeds/test/chrome/test_bug408328.html too)
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Tracking
(firefox29 fixed, firefox30 fixed, firefox31 fixed, firefox-esr24 wontfix, b2g-v1.2 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)
People
(Reporter: mcmanus, Assigned: froydnj)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
1.33 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
The test infrastrucutre is meant to be self contained - so xpcshell, mochitests, and crashtests need to be self hosted. browser/base/content/test/general/test_bug364677.html connects to yahoo everytime by making a channel request for http://add.my.yahoo.com/favicon.ico should be fixed to be localhost only
Reporter | ||
Comment 1•10 years ago
|
||
browser/components/feeds/test/chrome/test_bug408328.html has the same problem.
Summary: browser/base/content/test/general/test_bug364677.html connects to yahoo everytime → browser/base/content/test/general/test_bug364677.html connects to yahoo everytime (browser/components/feeds/test/chrome/test_bug408328.html too)
Comment 2•10 years ago
|
||
That's the behavior of the feed preview page: when you load a feed in it, it requests the favicons for all of the web-based feed handlers, for the drop-down menu. Since the demise of Google Reader, "all of the web-based feed handlers" is Yahoo. Probably the correct fix is Core::Testing, setting all the browser.contentHandlers.types.n.uri prefs we support (I think up to 5, though en-US only uses 0) to example.com.
Assignee | ||
Comment 3•10 years ago
|
||
philor++ for pointing out where to find all this. The relevant tests still seem to pass locally.
Assignee | ||
Updated•10 years ago
|
Attachment #8407110 -
Flags: review?(jmaher)
Comment 4•10 years ago
|
||
Comment on attachment 8407110 [details] [diff] [review] set testing prefs to redirect to the test proxy server for RSS feeds Review of attachment 8407110 [details] [diff] [review]: ----------------------------------------------------------------- this is good- any chance we need this on talos? For the redirect to a rss feed, do we get errors or put the browser in an odd state? ::: testing/profiles/prefs_general.js @@ +184,5 @@ > +user_pref('browser.contentHandlers.types.1.uri', 'http://test1.example.org/rss?url=%%s') > +user_pref('browser.contentHandlers.types.2.uri', 'http://test1.example.org/rss?url=%%s') > +user_pref('browser.contentHandlers.types.3.uri', 'http://test1.example.org/rss?url=%%s') > +user_pref('browser.contentHandlers.types.4.uri', 'http://test1.example.org/rss?url=%%s') > +user_pref('browser.contentHandlers.types.5.uri', 'http://test1.example.org/rss?url=%%s') any chance we will need types.6.uri, types.7.uri, etc. ?
Attachment #8407110 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #4) > this is good- any chance we need this on talos? Not unless we decide to impose the same "no external connections" discipline on Talos. > For the redirect to a rss feed, do we get errors or put the browser in an > odd state? It doesn't look like it in local testing, though I haven't run the full suite on Try. > ::: testing/profiles/prefs_general.js > @@ +184,5 @@ > > +user_pref('browser.contentHandlers.types.1.uri', 'http://test1.example.org/rss?url=%%s') > > +user_pref('browser.contentHandlers.types.2.uri', 'http://test1.example.org/rss?url=%%s') > > +user_pref('browser.contentHandlers.types.3.uri', 'http://test1.example.org/rss?url=%%s') > > +user_pref('browser.contentHandlers.types.4.uri', 'http://test1.example.org/rss?url=%%s') > > +user_pref('browser.contentHandlers.types.5.uri', 'http://test1.example.org/rss?url=%%s') > > any chance we will need types.6.uri, types.7.uri, etc. ? I hope not! Ideally we will get "no external connections" in place before they are needed anyway.
Comment 6•10 years ago
|
||
thanks
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6863631867ea
Flags: in-testsuite-
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → nfroyd
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6863631867ea
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/47a15ec03ea7 https://hg.mozilla.org/releases/mozilla-beta/rev/ba1c380f55b9 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/250651818454 https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/24e587db88d1 https://hg.mozilla.org/releases/mozilla-esr24/rev/32bb91602986
status-b2g-v1.2:
--- → fixed
status-b2g-v1.3:
--- → fixed
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-firefox29:
--- → fixed
status-firefox30:
--- → fixed
status-firefox31:
--- → fixed
status-firefox-esr24:
--- → fixed
Comment 10•10 years ago
|
||
Backed out from esr24 for mochitest bustage. https://hg.mozilla.org/releases/mozilla-esr24/rev/f83ea29de6a1
Updated•10 years ago
|
status-b2g-v1.3T:
--- → fixed
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•