995995 - browser/base/content/test/general/test_bug364677.html connects to yahoo everytime (browser/components/feeds/test/chrome/test_bug408328.html too)

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Patrick McManus [:mcmanus]]

The test infrastrucutre is meant to be self contained - so xpcshell, mochitests, and crashtests need to be self hosted.

browser/base/content/test/general/test_bug364677.html connects to yahoo everytime by making a channel request for http://add.my.yahoo.com/favicon.ico

should be fixed to be localhost only

Comment 1

[Patrick McManus [:mcmanus]]

browser/components/feeds/test/chrome/test_bug408328.html has the same problem.

Comment 2

[Phil Ringnalda (:philor)]

That's the behavior of the feed preview page: when you load a feed in it, it requests the favicons for all of the web-based feed handlers, for the drop-down menu. Since the demise of Google Reader, "all of the web-based feed handlers" is Yahoo.

Probably the correct fix is Core::Testing, setting all the browser.contentHandlers.types.n.uri prefs we support (I think up to 5, though en-US only uses 0) to example.com.

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: set testing prefs to redirect to the test proxy server for RSS feeds

philor++ for pointing out where to find all this.  The relevant tests still
seem to pass locally.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8407110 [details] [diff] [review]
set testing prefs to redirect to the test proxy server for RSS feeds

Review of attachment 8407110 [details] [diff] [review]:
-----------------------------------------------------------------

this is good- any chance we need this on talos?

For the redirect to a rss feed, do we get errors or put the browser in an odd state?

::: testing/profiles/prefs_general.js
@@ +184,5 @@
> +user_pref('browser.contentHandlers.types.1.uri', 'http://test1.example.org/rss?url=%%s')
> +user_pref('browser.contentHandlers.types.2.uri', 'http://test1.example.org/rss?url=%%s')
> +user_pref('browser.contentHandlers.types.3.uri', 'http://test1.example.org/rss?url=%%s')
> +user_pref('browser.contentHandlers.types.4.uri', 'http://test1.example.org/rss?url=%%s')
> +user_pref('browser.contentHandlers.types.5.uri', 'http://test1.example.org/rss?url=%%s')

any chance we will need types.6.uri, types.7.uri, etc. ?

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Joel Maher (:jmaher) from comment #4)
> this is good- any chance we need this on talos?

Not unless we decide to impose the same "no external connections" discipline on Talos.

> For the redirect to a rss feed, do we get errors or put the browser in an
> odd state?

It doesn't look like it in local testing, though I haven't run the full suite on Try.

> ::: testing/profiles/prefs_general.js
> @@ +184,5 @@
> > +user_pref('browser.contentHandlers.types.1.uri', 'http://test1.example.org/rss?url=%%s')
> > +user_pref('browser.contentHandlers.types.2.uri', 'http://test1.example.org/rss?url=%%s')
> > +user_pref('browser.contentHandlers.types.3.uri', 'http://test1.example.org/rss?url=%%s')
> > +user_pref('browser.contentHandlers.types.4.uri', 'http://test1.example.org/rss?url=%%s')
> > +user_pref('browser.contentHandlers.types.5.uri', 'http://test1.example.org/rss?url=%%s')
> 
> any chance we will need types.6.uri, types.7.uri, etc. ?

I hope not!  Ideally we will get "no external connections" in place before they are needed anyway.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6863631867ea

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6863631867ea

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47a15ec03ea7
https://hg.mozilla.org/releases/mozilla-beta/rev/ba1c380f55b9
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/250651818454
https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/24e587db88d1
https://hg.mozilla.org/releases/mozilla-esr24/rev/32bb91602986

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Backed out from esr24 for mochitest bustage.
https://hg.mozilla.org/releases/mozilla-esr24/rev/f83ea29de6a1