Closed
Bug 99613
Opened 24 years ago
Closed 24 years ago
Freeze nsIWebBrowserFind
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.7
People
(Reporter: chak, Assigned: ccarlen)
References
Details
Attachments
(1 file)
|
3.85 KB,
patch
|
chak
:
review+
|
Details | Diff | Splinter Review |
Freeze nsIWebBrowserFind.
Please refer to
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the
issues to be addressed, if any, for this interface.
Please follow the guidelines outlined in "How to mark an interface as frozen?"
section of the document above.
| Assignee | ||
Comment 2•24 years ago
|
||
Accepting.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Updated•24 years ago
|
QA Contact: mdunn → depstein
Comment 3•24 years ago
|
||
Comment 4•24 years ago
|
||
Notice how the comments, as Simon provided, have the name of the method or
attribute in the comment block. I think this makes it more readable, but it's
not consistent with our other FROZEN ifaces. Chak - any opinions on this?
| Reporter | ||
Comment 5•24 years ago
|
||
I agree that having the name of the method or attribute in the comment block
makes it more readable.
I'll update the current document to reflect this...Thanks
| Assignee | ||
Comment 6•24 years ago
|
||
Simon can you give the sr on freezing this one?
Comment 7•24 years ago
|
||
sr=sfraser
Note that not all the FindInFrame stuff works though (search sub frames, search
parent frames).
Comment 10•24 years ago
|
||
We're going to forgoe the FindFromTop piece if this, so, let's move forward w/
the checkin as is.
| Assignee | ||
Comment 11•24 years ago
|
||
chak, can you r=
| Reporter | ||
Comment 12•24 years ago
|
||
Comment on attachment 50249 [details] [diff] [review]
minor changes + FROZEN
r=chak
Attachment #50249 -
Flags: review+
| Assignee | ||
Comment 13•24 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 14•24 years ago
|
||
idl indicated as frozen and comments updated. Verified in 12/14/01 mozilla
build. Just one spelling error in nsIWebBrowserFind.idl:
"Wether to match entire words only".
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•