99617 - Freeze nsIWebBrowserChrome

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Chak Nanga]

Freeze nsIWebBrowserChrome

Please refer to
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the
issues to be addressed, if any, for this interface.

Please follow the guidelines outlined in "How to mark an interface as frozen?"
section of the document above.

Comment 1

[Chak Nanga]

->0.9.6

Hi Dan : 

Do you think we can get this into 0.9.6...

Thanks
Chak

Comment 2

[David Epstein]

change qa contact to Dharma.

Comment 3

[Judson Valeski]

actually re-nominating this one pending a ping of Adam Lock re: some issues he
*may* have had.

Comment 4

[Dan M]

Attachment: freeze nsIWebBrowserChrome

Comment 5

[Chak Nanga]

Comment on attachment 78268 [details] [diff] [review]
freeze nsIWebBrowserChrome

r=chak

Comment 6

[rpotts (gone)]

Comment on attachment 78268 [details] [diff] [review]
freeze nsIWebBrowserChrome

sr=[e-mail]

Comment 7

[rpotts (gone)]

I forget...  what did we decide about using the '@throws' or '@exception'
javadoc keyword?

Do you think we should use it to document the possible 'return value' for
'showAsModal()' at least?  Since 'exitModalEventLoop()' says that its argument
*is* the return value for showAsModal...

-- rick

Comment 8

[timeless]

arg. no no no no..

1. don't use nsnull, use null
2. tehere should be *'s on each line in the comments (i think)
3. i'm pretty sure we picked @throws
4. please don't freeze while changing
5. i'm not sure 1999,2002 is correct please find a lawyer to approve that.
+      The chrome flags for this browser chrome. The implementation should
+      reflect the value of this attribute by hiding or showing its chrome
+      appropriately.
6. 'browser chrome' is starting to rub me the wrong way. In some cases I 
suspect 'chrome' means 'widgets' or 'controls' in others i suspect it means 
'window'.
7. webBrowser or webbrowser, please be consistent. keep in mind this is 
documentation, not geek speak. I think 'web browser', unless you have a very 
compelling reason to use something else.
+      webbrowser object.
you could just say 'browser', dropping both web and object.


<sarcasm title="Good Paralellism">
+      Is the window modal (that is, currently executing a modal loop)?
+      @return true if it's a modal window
     */
     boolean isWindowModal();
...
+      Exit a modal event loop if we're in one. The implementation
+      should also exit out of the loop if the window is destroyed.
+      @param aStatus - the result code to return from showAsModal
     */
     void exitModalEventLoop(in nsresult aStatus);
</sarcasm>

chak: your r='s have continuously disappointed me. as have rpott's sr's

Comment 9

[tao]

adt1.0.0+ on behalf of ADT: inline comments are good doc to developers.

Comment 10

[Dan M]

interface is now frozen on the trunk and 1.0 branch. actual patch addressed from
timeless' comment 8 points 1,2,7. 3 doesn't really apply to this file; 4 doesn't
seem to be an issue (no one had a real objection to freezing this interface now,
and it's high time); 5 is surprisingly hard to find an authoritative ruling on,
but Mitchell says it's probably the correct way to do it; 6 is pretty much
beyond the scope of this bug.

Comment 11

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 12

[David Epstein]

verified comment updates in nsIWebBrowserChrome.idl