Closed
Bug 99618
Opened 23 years ago
Closed 23 years ago
Freeze nsIWindowWatcher
Categories
(Core Graveyard :: Embedding: APIs, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: chak, Assigned: danm.moz)
References
Details
(Keywords: embed, topembed+)
Attachments
(1 file)
|
2.83 KB,
patch
|
chak
:
review+
jud
:
superreview+
jud
:
approval+
|
Details | Diff | Splinter Review |
Freeze nsIWindowWatcher Please refer to http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the issues to be addressed, if any, for this interface. Please follow the guidelines outlined in "How to mark an interface as frozen?" section of the document above.
|
||
Updated•23 years ago
|
QA Contact: mdunn → depstein
|
||
Updated•23 years ago
|
|
||
Updated•23 years ago
|
|
Reporter | |
Comment 3•23 years ago
|
||
Comment on attachment 78270 [details] [diff] [review] freeze nsIWindowWatcher r=chak
Attachment #78270 -
Flags: review+
|
||
Comment 4•23 years ago
|
||
Comment on attachment 78270 [details] [diff] [review] freeze nsIWindowWatcher sr=rpotts@netscape.com
> Embedding clients need do nothing special about that requirement.
that's /awk/ward.
If some of these methods are [notxpcom] or [noscript] please mark them before
freezing. I'm sure i filed a bug about this somewhere. If you need help
finding the bug or need to talk with me, i'll leave my phone number with danm.timeless: all the methods in this interface are intended to be scriptable. If by awkward you mean the wording; eh, I like it.
|
|
||
Comment 8•23 years ago
|
||
Comment on attachment 78270 [details] [diff] [review] freeze nsIWindowWatcher carrying rpotts' sr over and approving.
Attachment #78270 -
Flags: superreview+
Attachment #78270 -
Flags: approval+
interface is now frozen on the trunk and 1.0 branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Comment 10•23 years ago
|
||
looks good, except comments for registerNotification() include 3 non-existent parameters: aSubject, aTopic, someData.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
Assignee | |
Comment 11•23 years ago
|
||
I suppose you're right; it's probably not cricket to describe those parameters using the @param keyword. fixed.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
|
||
Comment 13•23 years ago
|
||
adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword with verified1.0.0.
Keywords: fixed1.0.0
|
|
||
Updated•23 years ago
|
Keywords: fixed1.0.0 → verified1.0.0
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•