99618 - Freeze nsIWindowWatcher

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Chak Nanga]

Freeze nsIWindowWatcher

Please refer to
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for the
issues to be addressed, if any, for this interface.

Please follow the guidelines outlined in "How to mark an interface as frozen?"
section of the document above.

Comment 1

[Chak Nanga]

->0.9.6

Comment 2

[Dan M]

Attachment: freeze nsIWindowWatcher

Comment 3

[Chak Nanga]

Comment on attachment 78270 [details] [diff] [review]
freeze nsIWindowWatcher

r=chak

Comment 4

[rpotts (gone)]

Comment on attachment 78270 [details] [diff] [review]
freeze nsIWindowWatcher

sr=[e-mail]

Comment 5

[timeless]

> Embedding clients need do nothing special about that requirement.
that's /awk/ward.

If some of these methods are [notxpcom] or [noscript] please mark them before 
freezing. I'm sure i filed a bug about this somewhere.  If you  need help 
finding the bug or need to talk with me, i'll leave my phone number with danm.

Comment 6

[Dan M]

timeless: all the methods in this interface are intended to be scriptable. If by
awkward you mean the wording; eh, I like it.

Comment 7

[tao]

adt1.0.0+ on behalf of ADT: inline comments are good doc to developers.

Comment 8

[Judson Valeski]

Comment on attachment 78270 [details] [diff] [review]
freeze nsIWindowWatcher

carrying rpotts' sr over and approving.

Comment 9

[Dan M]

interface is now frozen on the trunk and 1.0 branch.

Comment 10

[David Epstein]

looks good, except comments for registerNotification() include 3 non-existent
parameters: aSubject, aTopic, someData.

Comment 11

[Dan M]

I suppose you're right; it's probably not cricket to describe those parameters
using the @param keyword. fixed.

Comment 12

[David Epstein]

verified.

Comment 13

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.